mm: /proc/pid/smaps_rollup: fix no vma's null-deref
authorSeth Jenkins <sethjenkins@google.com>
Thu, 27 Oct 2022 15:36:52 +0000 (11:36 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 29 Oct 2022 08:12:58 +0000 (10:12 +0200)
Commit 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value
seq_file") introduced a null-deref if there are no vma's in the task in
show_smaps_rollup.

Fixes: 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value seq_file")
Signed-off-by: Seth Jenkins <sethjenkins@google.com>
Reviewed-by: Alexey Dobriyan <adobriyan@gmail.com>
Tested-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/proc/task_mmu.c

index d9c07ee..c3b7674 100644 (file)
@@ -951,7 +951,7 @@ static int show_smaps_rollup(struct seq_file *m, void *v)
                vma = vma->vm_next;
        }
 
-       show_vma_header_prefix(m, priv->mm->mmap->vm_start,
+       show_vma_header_prefix(m, priv->mm->mmap ? priv->mm->mmap->vm_start : 0,
                               last_vma_end, 0, 0, 0, 0);
        seq_pad(m, ' ');
        seq_puts(m, "[rollup]\n");