dmaengine: idxd: remove devm allocation for idxd->int_handles
authorDave Jiang <dave.jiang@intel.com>
Mon, 10 May 2021 00:38:25 +0000 (17:38 -0700)
committerVinod Koul <vkoul@kernel.org>
Mon, 10 May 2021 15:50:15 +0000 (21:20 +0530)
Allocation of idxd->int_handles was merged incorrectly for the 5.13 merge
window. The devm_kcalloc should've been regular kcalloc due to devm_*
removal series for the driver.

Fixes: eb15e7154fbf ("dmaengine: idxd: add interrupt handle request and release support")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/162060710518.130816.11349798049329202863.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/init.c

index 2a926be..21d3dcb 100644 (file)
@@ -311,7 +311,8 @@ static int idxd_setup_internals(struct idxd_device *idxd)
        init_waitqueue_head(&idxd->cmd_waitq);
 
        if (idxd->hw.cmd_cap & BIT(IDXD_CMD_REQUEST_INT_HANDLE)) {
-               idxd->int_handles = devm_kcalloc(dev, idxd->max_wqs, sizeof(int), GFP_KERNEL);
+               idxd->int_handles = kcalloc_node(idxd->max_wqs, sizeof(int), GFP_KERNEL,
+                                                dev_to_node(dev));
                if (!idxd->int_handles)
                        return -ENOMEM;
        }