Fix: Be more consistent with other boundary checks
authorDenis Kenzior <denkenz@gmail.com>
Wed, 31 Mar 2010 17:22:57 +0000 (12:22 -0500)
committerDenis Kenzior <denkenz@gmail.com>
Wed, 31 Mar 2010 17:22:57 +0000 (12:22 -0500)
src/stkutil.c

index 1125d61..b61ff39 100644 (file)
@@ -359,7 +359,7 @@ static gboolean parse_dataobj_gsm_sms_tpdu(struct comprehension_tlv_iter *iter,
        unsigned int len;
 
        len = comprehension_tlv_iter_get_length(iter);
-       if (len < 1 || len > 164)
+       if (len < 1 || len > sizeof(tpdu->tpdu))
                return FALSE;
 
        data = comprehension_tlv_iter_get_data(iter);
@@ -780,7 +780,7 @@ static gboolean parse_dataobj_text_attr(struct comprehension_tlv_iter *iter,
 
        len = comprehension_tlv_iter_get_length(iter);
 
-       if (len > 127)
+       if (len > sizeof(attr->attributes))
                return FALSE;
 
        data = comprehension_tlv_iter_get_data(iter);