Revert Add a use counter for Intl.v8BreakIterator https://codereview.chromium.org...

This is due to breakage on the ASAN memory leak bot, possibly due to
pre-existing leaks in v8BreakIterator().

R=ishell@chromium.org
BUG=

Review URL: https://codereview.chromium.org/636493004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24409 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/include/v8.h b/include/v8.h
index 7a1c479cc427d69abeecd1e235f2e979e1859e3c..2dc1bd81af8ce5bbd2a8ac0ed30f5f00eefc79b2 100644 (file)
--- a/include/v8.h
+++ b/include/v8.h
@@ -4528,7 +4528,6 @@ class V8_EXPORT Isolate {
    */
   enum UseCounterFeature {
     kUseAsm = 0,
-    kBreakIterator = 1,
     kUseCounterFeatureCount  // This enum value must be last.
   };
 

diff --git a/src/i18n.cc b/src/i18n.cc
index ba44687aa90dd57932cc36f4feb3986004dac856..cae3a327a1b924b60edad2d9f326ccd01df2b6ad 100644 (file)
--- a/src/i18n.cc
+++ b/src/i18n.cc
@@ -631,8 +631,6 @@ icu::BreakIterator* CreateICUBreakIterator(
     return NULL;
   }
 
-  isolate->CountUsage(v8::Isolate::UseCounterFeature::kBreakIterator);
-
   return break_iterator;
 }
 

diff --git a/test/cctest/test-strings.cc b/test/cctest/test-strings.cc
index 88aa72fb00800e064091429aea05acb6d24ecc64..ef13c4dadf682f6e178dce71c9e70009d703a7e9 100644 (file)
--- a/test/cctest/test-strings.cc
+++ b/test/cctest/test-strings.cc
@@ -1292,35 +1292,6 @@ TEST(RobustSubStringStub) {
 }
 
 
-namespace {
-
-int* global_use_counts = NULL;
-
-void MockUseCounterCallback(v8::Isolate* isolate,
-                            v8::Isolate::UseCounterFeature feature) {
-  ++global_use_counts[feature];
-}
-}
-
-
-TEST(CountBreakIterator) {
-  CcTest::InitializeVM();
-  v8::HandleScope scope(CcTest::isolate());
-  LocalContext context;
-  int use_counts[v8::Isolate::kUseCounterFeatureCount] = {};
-  global_use_counts = use_counts;
-  CcTest::isolate()->SetUseCounterCallback(MockUseCounterCallback);
-  CHECK_EQ(0, use_counts[v8::Isolate::kBreakIterator]);
-  v8::Local<v8::Value> result = CompileRun(
-      "var iterator = Intl.v8BreakIterator(['en']);"
-      "iterator.adoptText('Now is the time');"
-      "iterator.next();"
-      "iterator.next();");
-  CHECK(result->IsNumber());
-  CHECK_EQ(1, use_counts[v8::Isolate::kBreakIterator]);
-}
-
-
 TEST(StringReplaceAtomTwoByteResult) {
   CcTest::InitializeVM();
   v8::HandleScope scope(CcTest::isolate());