analyze: return earlier when there is no path to be prepended
authorYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 24 Nov 2023 14:42:04 +0000 (23:42 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Sat, 25 Nov 2023 03:52:59 +0000 (12:52 +0900)
Follow-up for 2f6181ad4d6c126e3ebf6880ba30b3b0059c6fc8.

Addresses the post-merge comment:
https://github.com/systemd/systemd/pull/30172#discussion_r1404209035

src/analyze/analyze-verify-util.c

index f3ce0ad..26d1130 100644 (file)
@@ -98,13 +98,13 @@ int verify_set_unit_path(char **filenames) {
                         return r;
         }
 
+        if (strv_isempty(ans))
+                return 0;
+
         joined = strv_join(strv_uniq(ans), ":");
         if (!joined)
                 return -ENOMEM;
 
-        if (isempty(joined))
-                return 0;
-
         /* First, prepend our directories. Second, if some path was specified, use that, and
          * otherwise use the defaults. Any duplicates will be filtered out in path-lookup.c.
          * Treat explicit empty path to mean that nothing should be appended. */