Set auto_release's default parameter value

Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>

diff --git a/src/common/parcel/appinfo_parcelable.hh b/src/common/parcel/appinfo_parcelable.hh
index e216ec8..68f60a4 100644 (file)
--- a/src/common/parcel/appinfo_parcelable.hh
+++ b/src/common/parcel/appinfo_parcelable.hh
@@ -17,7 +17,7 @@ namespace parcel {
 class EXPORT_API AppInfoParcelable : public AbstractParcelable {
  public:
   AppInfoParcelable();
-  AppInfoParcelable(int ret, std::vector<application_x *>&& app_list, bool auto_release);
+  AppInfoParcelable(int ret, std::vector<application_x *>&& app_list, bool auto_release = true);
   ~AppInfoParcelable();
   const std::vector<application_x *>& GetAppInfo();
   std::vector<application_x *>&& ExtractAppInfo();

diff --git a/src/common/parcel/certinfo_parcelable.hh b/src/common/parcel/certinfo_parcelable.hh
index 8ab08fe..b0dc567 100644 (file)
--- a/src/common/parcel/certinfo_parcelable.hh
+++ b/src/common/parcel/certinfo_parcelable.hh
@@ -19,10 +19,10 @@ class EXPORT_API CertInfoParcelable : public AbstractParcelable {
  public:
   CertInfoParcelable();
   CertInfoParcelable(uid_t uid, std::string pkgid);
-  CertInfoParcelable(uid_t uid, pkgmgr_certinfo_x *cert_info, bool auto_release);
-  CertInfoParcelable(int ret, pkgmgr_certinfo_x *cert_info, bool auto_release);
+  CertInfoParcelable(uid_t uid, pkgmgr_certinfo_x *cert_info, bool auto_release = true);
+  CertInfoParcelable(int ret, pkgmgr_certinfo_x *cert_info, bool auto_release = true);
   CertInfoParcelable(uid_t uid,
-      pkgmgr_certinfo_x *cert_info, std::string pkgid, bool auto_release);
+      pkgmgr_certinfo_x *cert_info, std::string pkgid, bool auto_release = true);
   ~CertInfoParcelable();
   const pkgmgr_certinfo_x *GetCertInfo();
   pkgmgr_certinfo_x *ExtractCertInfo();

diff --git a/src/common/parcel/depinfo_parcelable.hh b/src/common/parcel/depinfo_parcelable.hh
index 0dcce22..c78e778 100644 (file)
--- a/src/common/parcel/depinfo_parcelable.hh
+++ b/src/common/parcel/depinfo_parcelable.hh
@@ -17,7 +17,7 @@ namespace parcel {
 class EXPORT_API DepInfoParcelable : public AbstractParcelable {
  public:
   DepInfoParcelable();
-  DepInfoParcelable(int ret, std::vector<dependency_x *>&& dependency_list, bool auto_release);
+  DepInfoParcelable(int ret, std::vector<dependency_x *>&& dependency_list, bool auto_release = true);
   DepInfoParcelable(const std::string& pkgid);
   ~DepInfoParcelable();
   const std::vector<dependency_x *>& GetDependencyInfo();

diff --git a/src/common/parcel/filter_parcelable.hh b/src/common/parcel/filter_parcelable.hh
index cc3d210..9615fc7 100644 (file)
--- a/src/common/parcel/filter_parcelable.hh
+++ b/src/common/parcel/filter_parcelable.hh
@@ -17,7 +17,7 @@ namespace parcel {
 class EXPORT_API FilterParcelable : public AbstractParcelable {
  public:
   FilterParcelable();
-  FilterParcelable(uid_t uid, pkgmgrinfo_filter_x *filter, int flag, bool auto_release);
+  FilterParcelable(uid_t uid, pkgmgrinfo_filter_x *filter, int flag, bool auto_release = true);
   ~FilterParcelable();
   const pkgmgrinfo_filter_x* GetFilter();
   int GetFlag();

diff --git a/src/common/parcel/pkginfo_parcelable.hh b/src/common/parcel/pkginfo_parcelable.hh
index 24b1d82..1c0d8c3 100644 (file)
--- a/src/common/parcel/pkginfo_parcelable.hh
+++ b/src/common/parcel/pkginfo_parcelable.hh
@@ -18,8 +18,8 @@ namespace parcel {
 class EXPORT_API PkgInfoParcelable : public AbstractParcelable {
  public:
   PkgInfoParcelable();
-  PkgInfoParcelable(uid_t uid, std::vector<package_x *>&& pkg_list, WriteType write_type, bool auto_release);
-  PkgInfoParcelable(int ret, std::vector<package_x *>&& pkg_list, bool auto_release);
+  PkgInfoParcelable(uid_t uid, std::vector<package_x *>&& pkg_list, WriteType write_type, bool auto_release = true);
+  PkgInfoParcelable(int ret, std::vector<package_x *>&& pkg_list, bool auto_release = true);
   ~PkgInfoParcelable();
   const std::vector<package_x *>& GetPkgInfo();
   std::vector<package_x *>&& ExtractPkgInfo();

diff --git a/src/common/request_handler/get_appinfo_request_handler.cc b/src/common/request_handler/get_appinfo_request_handler.cc
index 6987a39..049f0de 100644 (file)
--- a/src/common/request_handler/get_appinfo_request_handler.cc
+++ b/src/common/request_handler/get_appinfo_request_handler.cc
@@ -25,7 +25,7 @@ bool GetAppinfoRequestHandler::HandleRequest(unsigned char* data, int size,
       abstract_parcel->GetType() != ParcelableType::Filter) {
     _LOGE("Invalid parcel or type");
     result_ = std::make_shared<AppInfoParcelable>(
-        PMINFO_R_ERROR, std::vector<application_x*>{}, true);
+        PMINFO_R_ERROR, std::vector<application_x*>{});
     return false;
   }
 
@@ -33,7 +33,7 @@ bool GetAppinfoRequestHandler::HandleRequest(unsigned char* data, int size,
   if (parcel == nullptr) {
     _LOGE("Parcel is empty");
     result_ = std::make_shared<AppInfoParcelable>(
-        PMINFO_R_ERROR, std::vector<application_x*>{}, true);
+        PMINFO_R_ERROR, std::vector<application_x*>{});
     return false;
   }
 
@@ -44,7 +44,7 @@ bool GetAppinfoRequestHandler::HandleRequest(unsigned char* data, int size,
   if (ret < 0)
     _LOGE("Failed to execute");
 
-  result_ = std::make_shared<AppInfoParcelable>(ret, db.GetAppHandle(), true);
+  result_ = std::make_shared<AppInfoParcelable>(ret, db.GetAppHandle());
 
   return true;
 }

diff --git a/src/common/request_handler/get_cert_request_handler.cc b/src/common/request_handler/get_cert_request_handler.cc
index b12f823..ee31472 100644 (file)
--- a/src/common/request_handler/get_cert_request_handler.cc
+++ b/src/common/request_handler/get_cert_request_handler.cc
@@ -24,7 +24,7 @@ bool GetCertRequestHandler::HandleRequest(unsigned char* data, int size,
       abstract_parcel->GetType() != ParcelableType::CertInfo) {
     _LOGE("Invalid parcel or type");
     result_ = std::make_shared<CertInfoParcelable>(
-        PMINFO_R_ERROR, nullptr, true);
+        PMINFO_R_ERROR, nullptr);
     return false;
   }
 
@@ -32,7 +32,7 @@ bool GetCertRequestHandler::HandleRequest(unsigned char* data, int size,
   if (parcel == nullptr) {
     _LOGE("Parcel is empty");
     result_ = std::make_shared<CertInfoParcelable>(
-        PMINFO_R_ERROR, nullptr, true);
+        PMINFO_R_ERROR, nullptr);
     return false;
   }
 
@@ -42,7 +42,7 @@ bool GetCertRequestHandler::HandleRequest(unsigned char* data, int size,
 
   int ret = db.Execute();
 
-  result_ = std::make_shared<CertInfoParcelable>(ret, db.GetCertHandle(), true);
+  result_ = std::make_shared<CertInfoParcelable>(ret, db.GetCertHandle());
 
   return true;
 }

diff --git a/src/common/request_handler/get_depinfo_request_handler.cc b/src/common/request_handler/get_depinfo_request_handler.cc
index 35587b8..c9c4aba 100644 (file)
--- a/src/common/request_handler/get_depinfo_request_handler.cc
+++ b/src/common/request_handler/get_depinfo_request_handler.cc
@@ -25,7 +25,7 @@ bool GetDepinfoRequestHandler::HandleRequest(unsigned char* data, int size,
       abstract_parcel->GetType() != ParcelableType::DepInfo) {
     _LOGE("Invalid parcel or type");
     result_ = std::make_shared<DepInfoParcelable>(
-        PMINFO_R_ERROR, std::vector<dependency_x*>{}, true);
+        PMINFO_R_ERROR, std::vector<dependency_x*>{});
     return false;
   }
 
@@ -33,7 +33,7 @@ bool GetDepinfoRequestHandler::HandleRequest(unsigned char* data, int size,
   if (parcel == nullptr) {
     _LOGE("Parcel is empty");
     result_ = std::make_shared<DepInfoParcelable>(
-        PMINFO_R_ERROR, std::vector<dependency_x*>{}, true);
+        PMINFO_R_ERROR, std::vector<dependency_x*>{});
     return false;
   }
 
@@ -41,7 +41,7 @@ bool GetDepinfoRequestHandler::HandleRequest(unsigned char* data, int size,
   db.SetPkgID(parcel->GetPkgID());
   int ret = db.Execute();
 
-  result_ = std::make_shared<DepInfoParcelable>(ret, db.GetDependencyList(), true);
+  result_ = std::make_shared<DepInfoParcelable>(ret, db.GetDependencyList());
   return true;
 }
 

diff --git a/src/common/request_handler/get_pkginfo_request_handler.cc b/src/common/request_handler/get_pkginfo_request_handler.cc
index 306330a..0307c11 100644 (file)
--- a/src/common/request_handler/get_pkginfo_request_handler.cc
+++ b/src/common/request_handler/get_pkginfo_request_handler.cc
@@ -25,7 +25,7 @@ bool GetPkginfoRequestHandler::HandleRequest(unsigned char* data, int size,
       abstract_parcel->GetType() != ParcelableType::Filter) {
     _LOGE("Invalid parcel or type");
     result_ = std::make_shared<PkgInfoParcelable>(
-        PMINFO_R_ERROR, std::vector<package_x*>{}, true);
+        PMINFO_R_ERROR, std::vector<package_x*>{});
     return false;
   }
 
@@ -33,7 +33,7 @@ bool GetPkginfoRequestHandler::HandleRequest(unsigned char* data, int size,
   if (parcel == nullptr) {
     _LOGE("Parcel is empty");
     result_ = std::make_shared<PkgInfoParcelable>(
-        PMINFO_R_ERROR, std::vector<package_x*>{}, true);
+        PMINFO_R_ERROR, std::vector<package_x*>{});
     return false;
   }
 
@@ -42,7 +42,7 @@ bool GetPkginfoRequestHandler::HandleRequest(unsigned char* data, int size,
   db.SetFilter(const_cast<pkgmgrinfo_filter_x*>(parcel->GetFilter()));
   int ret = db.Execute();
 
-  result_ = std::make_shared<PkgInfoParcelable>(ret, db.GetPkgHandle(), true);
+  result_ = std::make_shared<PkgInfoParcelable>(ret, db.GetPkgHandle());
 
   return true;
 }

diff --git a/test/unit_tests/test_parcel.cc b/test/unit_tests/test_parcel.cc
index ccbc756..d6be955 100644 (file)
--- a/test/unit_tests/test_parcel.cc
+++ b/test/unit_tests/test_parcel.cc
@@ -107,7 +107,7 @@ TEST_F(ParcelTest, AppInfoParcelable) {
 
   origin_applications.emplace_back(GetTestApplication("test_appid1"));
   origin_applications.emplace_back(GetTestApplication("test_appid2"));
-  pp::AppInfoParcelable origin_parcelable(0, std::move(origin_applications), true);
+  pp::AppInfoParcelable origin_parcelable(0, std::move(origin_applications));
   pp::AppInfoParcelable new_parcelable;
   parcel.WriteParcelable(origin_parcelable);
   parcel.ReadParcelable(&new_parcelable);
@@ -122,7 +122,7 @@ TEST_F(ParcelTest, PkgInfoParcelable) {
 
   origin_packages.emplace_back(GetTestPackage("test_pkgid1"));
   origin_packages.emplace_back(GetTestPackage("test_pkgid2"));
-  pp::PkgInfoParcelable origin_parcelable(0, std::move(origin_packages), true);
+  pp::PkgInfoParcelable origin_parcelable(0, std::move(origin_packages));
   pp::PkgInfoParcelable new_parcelable;
   parcel.WriteParcelable(origin_parcelable);
   parcel.ReadParcelable(&new_parcelable);
@@ -136,7 +136,7 @@ TEST_F(ParcelTest, FilterParcelable) {
   pkgmgrinfo_filter_x *filter = GetTestFilter();
   int flag = 0b101010;
 
-  pp::FilterParcelable origin_parcelable(0, filter, flag, true);
+  pp::FilterParcelable origin_parcelable(0, filter, flag);
   pp::FilterParcelable new_parcelable;
   parcel.WriteParcelable(origin_parcelable);
   parcel.ReadParcelable(&new_parcelable);
@@ -151,7 +151,7 @@ TEST_F(ParcelTest, CertInfoParcelable) {
   pkgmgr_certinfo_x *certinfo = GetTestCertInfo();
   std::string test_str = "test_str";
 
-  pp::CertInfoParcelable origin_parcelable(0, certinfo, test_str, true);
+  pp::CertInfoParcelable origin_parcelable(0, certinfo, test_str);
   pp::CertInfoParcelable new_parcelable;
   parcel.WriteParcelable(origin_parcelable);
   parcel.ReadParcelable(&new_parcelable);