enable Proxy_UseEnvironmentVariableToSetSystemProxy_RequestGoesThruProxy test (#34444)
authorJan Jahoda <jajahoda@microsoft.com>
Thu, 23 Apr 2020 09:15:59 +0000 (11:15 +0200)
committerGitHub <noreply@github.com>
Thu, 23 Apr 2020 09:15:59 +0000 (11:15 +0200)
* Disable test on windows and enable on other platforms

* enable test

* Add diag logs

* enhance logging

* Add body logging

* Add more logs

* Add logs to loopback server

* add trace

* Disallow run test on WinHttpHandler and remove logs

* Clean up

* rename variable

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Proxy.cs

index 80ec9e2..8a30a89 100644 (file)
@@ -113,9 +113,10 @@ namespace System.Net.Http.Functional.Tests
             }
         }
 
+        public static bool IsSocketsHttpHandler => !HttpClientHandlerTestBase.IsWinHttpHandler;
+
         [OuterLoop("Uses external server")]
-        [ConditionalFact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/33558")]        
+        [ConditionalFact(nameof(IsSocketsHttpHandler))]
         public void Proxy_UseEnvironmentVariableToSetSystemProxy_RequestGoesThruProxy()
         {
             RemoteExecutor.Invoke(async (useVersionString) =>