gpio: davinci: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 27 Aug 2020 20:08:23 +0000 (22:08 +0200)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Fri, 28 Aug 2020 18:15:06 +0000 (20:15 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-davinci.c

index 085b874..6f21385 100644 (file)
@@ -237,12 +237,8 @@ static int davinci_gpio_probe(struct platform_device *pdev)
 
        for (i = 0; i < nirq; i++) {
                chips->irqs[i] = platform_get_irq(pdev, i);
-               if (chips->irqs[i] < 0) {
-                       if (chips->irqs[i] != -EPROBE_DEFER)
-                               dev_info(dev, "IRQ not populated, err = %d\n",
-                                        chips->irqs[i]);
-                       return chips->irqs[i];
-               }
+               if (chips->irqs[i] < 0)
+                       return dev_err_probe(dev, chips->irqs[i], "IRQ not populated\n");
        }
 
        chips->chip.label = dev_name(dev);