usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable ...
authorLee Jones <lee.jones@linaro.org>
Mon, 6 Jul 2020 13:33:22 +0000 (14:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jul 2020 15:19:57 +0000 (17:19 +0200)
Looks like it's been this way since the driver's inception in 2007.

Fixes the following W=1 kernel build warning(s):

 drivers/usb/host/r8a66597-hcd.c: In function ‘clear_all_buffer’:
 drivers/usb/host/r8a66597-hcd.c:478:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]
 478 | u16 tmp;
 | ^~~

Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20200706133341.476881-14-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/r8a66597-hcd.c

index 0c03ac6..63719cd 100644 (file)
@@ -475,16 +475,14 @@ static void pipe_stop(struct r8a66597 *r8a66597, struct r8a66597_pipe *pipe)
 static void clear_all_buffer(struct r8a66597 *r8a66597,
                             struct r8a66597_pipe *pipe)
 {
-       u16 tmp;
-
        if (!pipe || pipe->info.pipenum == 0)
                return;
 
        pipe_stop(r8a66597, pipe);
        r8a66597_bset(r8a66597, ACLRM, pipe->pipectr);
-       tmp = r8a66597_read(r8a66597, pipe->pipectr);
-       tmp = r8a66597_read(r8a66597, pipe->pipectr);
-       tmp = r8a66597_read(r8a66597, pipe->pipectr);
+       r8a66597_read(r8a66597, pipe->pipectr);
+       r8a66597_read(r8a66597, pipe->pipectr);
+       r8a66597_read(r8a66597, pipe->pipectr);
        r8a66597_bclr(r8a66597, ACLRM, pipe->pipectr);
 }