regulator: qcom-labibb: Use disable_irq_nosync from isr

Calling the disable_irq() from irq handler might be a bad idea as
disable_irq() should wait for handlers to run. I don't see why
this wouldn't deadlock in wait_event waiting for the threaded
handler to complete.

Use disable_irq_nosync() instead.

Fixes: 390af53e04114 ("regulator: qcom-labibb: Implement short-circuit and over-current IRQs")

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reviewed-by: AngeloGioacchino Del Regno  <angelogioacchino.delregno@somainline.org>
Link: https://lore.kernel.org/r/f2c4c88d90bf7473e1b84b8a99b7b33d7a081764.1612249657.git.matti.vaittinen@fi.rohmeurope.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/regulator/qcom-labibb-regulator.c b/drivers/regulator/qcom-labibb-regulator.c
index dbb4511..de25e32 100644 (file)
--- a/drivers/regulator/qcom-labibb-regulator.c
+++ b/drivers/regulator/qcom-labibb-regulator.c
@@ -283,7 +283,7 @@ static irqreturn_t qcom_labibb_ocp_isr(int irq, void *chip)
         * Disable the interrupt temporarily, or it will fire continuously;
         * we will re-enable it in the recovery worker function.
         */
-       disable_irq(irq);
+       disable_irq_nosync(irq);
 
        /* Warn the user for overcurrent */
        dev_warn(vreg->dev, "Over-Current interrupt fired!\n");
@@ -536,7 +536,7 @@ static irqreturn_t qcom_labibb_sc_isr(int irq, void *chip)
         * Disable the interrupt temporarily, or it will fire continuously;
         * we will re-enable it in the recovery worker function.
         */
-       disable_irq(irq);
+       disable_irq_nosync(irq);
 
        /* Signal out of regulation event to drivers */
        regulator_notifier_call_chain(vreg->rdev,