Minor

diff --git a/src/Makefile.am b/src/Makefile.am
index e58bb50..7966dd0 100644 (file)
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -58,6 +58,7 @@ HBSOURCES += \
        hb-ot-shape-complex-indic.cc \
        hb-ot-shape-complex-indic-machine.hh \
        hb-ot-shape-complex-indic-table.hh \
+       hb-ot-shape-complex-misc.cc \
        hb-ot-shape-complex-private.hh \
        hb-ot-shape-private.hh \
        hb-ot-tag.cc \

diff --git a/src/hb-ot-shape-complex-misc.cc b/src/hb-ot-shape-complex-misc.cc
new file mode 100644 (file)
index 0000000..92dee49
--- /dev/null
+++ b/src/hb-ot-shape-complex-misc.cc
@@ -0,0 +1,51 @@
+/*
+ * Copyright © 2010  Google, Inc.
+ *
+ *  This is part of HarfBuzz, a text shaping library.
+ *
+ * Permission is hereby granted, without written agreement and without
+ * license or royalty fees, to use, copy, modify, and distribute this
+ * software and its documentation for any purpose, provided that the
+ * above copyright notice and the following two paragraphs appear in
+ * all copies of this software.
+ *
+ * IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE TO ANY PARTY FOR
+ * DIRECT, INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES
+ * ARISING OUT OF THE USE OF THIS SOFTWARE AND ITS DOCUMENTATION, EVEN
+ * IF THE COPYRIGHT HOLDER HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH
+ * DAMAGE.
+ *
+ * THE COPYRIGHT HOLDER SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING,
+ * BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
+ * FITNESS FOR A PARTICULAR PURPOSE.  THE SOFTWARE PROVIDED HEREUNDER IS
+ * ON AN "AS IS" BASIS, AND THE COPYRIGHT HOLDER HAS NO OBLIGATION TO
+ * PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
+ *
+ * Google Author(s): Behdad Esfahbod
+ */
+
+#include "hb-ot-shape-complex-private.hh"
+
+HB_BEGIN_DECLS
+
+/* TODO Add kana, hangul, and other small sahpers here */
+
+/* When adding trivial shapers, eg. kana, hangul, etc, we can either
+ * add a full shaper enum value for them, or switch on the script in
+ * the default complex shaper.  The former is faster, so I think that's
+ * what we would do, and hence the default complex shaper shall remain
+ * empty.
+ */
+
+void
+_hb_ot_shape_complex_collect_features_default (hb_ot_map_builder_t *map, const hb_segment_properties_t  *props)
+{
+}
+
+void
+_hb_ot_shape_complex_setup_masks_default (hb_ot_map_t *map, hb_buffer_t *buffer)
+{
+}
+
+
+HB_END_DECLS

diff --git a/src/hb-ot-shape-complex-private.hh b/src/hb-ot-shape-complex-private.hh
index bf79890..93268ba 100644 (file)
--- a/src/hb-ot-shape-complex-private.hh
+++ b/src/hb-ot-shape-complex-private.hh
@@ -40,7 +40,7 @@ HB_BEGIN_DECLS
 
 
 enum hb_ot_complex_shaper_t {
-  hb_ot_complex_shaper_none,
+  hb_ot_complex_shaper_default,
   hb_ot_complex_shaper_arabic,
   hb_ot_complex_shaper_indic
 };
@@ -104,7 +104,7 @@ hb_ot_shape_complex_categorize (const hb_segment_properties_t *props)
       return hb_ot_complex_shaper_indic;
 
     default:
-      return hb_ot_complex_shaper_none;
+      return hb_ot_complex_shaper_default;
   }
 }
 
@@ -119,6 +119,7 @@ hb_ot_shape_complex_categorize (const hb_segment_properties_t *props)
  */
 
 typedef void hb_ot_shape_complex_collect_features_func_t (hb_ot_map_builder_t *map, const hb_segment_properties_t  *props);
+HB_INTERNAL hb_ot_shape_complex_collect_features_func_t _hb_ot_shape_complex_collect_features_default;
 HB_INTERNAL hb_ot_shape_complex_collect_features_func_t _hb_ot_shape_complex_collect_features_arabic;
 HB_INTERNAL hb_ot_shape_complex_collect_features_func_t _hb_ot_shape_complex_collect_features_indic;
 
@@ -128,9 +129,10 @@ hb_ot_shape_complex_collect_features (hb_ot_complex_shaper_t shaper,
                                      const hb_segment_properties_t  *props)
 {
   switch (shaper) {
+    default:
+    case hb_ot_complex_shaper_default: _hb_ot_shape_complex_collect_features_default   (map, props);   return;
     case hb_ot_complex_shaper_arabic:  _hb_ot_shape_complex_collect_features_arabic    (map, props);   return;
     case hb_ot_complex_shaper_indic:   _hb_ot_shape_complex_collect_features_indic     (map, props);   return;
-    case hb_ot_complex_shaper_none:    default:                                                        return;
   }
 }
 
@@ -143,6 +145,7 @@ hb_ot_shape_complex_collect_features (hb_ot_complex_shaper_t shaper,
  */
 
 typedef void hb_ot_shape_complex_setup_masks_func_t (hb_ot_map_t *map, hb_buffer_t *buffer);
+HB_INTERNAL hb_ot_shape_complex_setup_masks_func_t _hb_ot_shape_complex_setup_masks_default;
 HB_INTERNAL hb_ot_shape_complex_setup_masks_func_t _hb_ot_shape_complex_setup_masks_arabic;
 HB_INTERNAL hb_ot_shape_complex_setup_masks_func_t _hb_ot_shape_complex_setup_masks_indic;
 
@@ -152,9 +155,10 @@ hb_ot_shape_complex_setup_masks (hb_ot_complex_shaper_t shaper,
                                 hb_buffer_t *buffer)
 {
   switch (shaper) {
+    default:
+    case hb_ot_complex_shaper_default: _hb_ot_shape_complex_setup_masks_default(map, buffer);  return;
     case hb_ot_complex_shaper_arabic:  _hb_ot_shape_complex_setup_masks_arabic (map, buffer);  return;
     case hb_ot_complex_shaper_indic:   _hb_ot_shape_complex_setup_masks_indic  (map, buffer);  return;
-    case hb_ot_complex_shaper_none:    default:                                                return;
   }
 }