staging: rtl8723bs: core: Use !x in place of NULL comparison.
authorVatsala Narang <vatsalanarang@gmail.com>
Wed, 1 May 2019 10:35:47 +0000 (16:05 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 May 2019 16:18:02 +0000 (18:18 +0200)
Avoid NULL comparison, compare using boolean operator.

Issue found using coccinelle.

Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_io.c
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c

index d341069..a92bc19 100644 (file)
@@ -156,7 +156,7 @@ int rtw_init_io_priv(struct adapter *padapter, void (*set_intf_ops)(struct adapt
        struct io_priv *piopriv = &padapter->iopriv;
        struct intf_hdl *pintf = &piopriv->intf;
 
-       if (set_intf_ops == NULL)
+       if (!set_intf_ops)
                return _FAIL;
 
        piopriv->padapter = padapter;
index 67b8840..bdc52d8 100644 (file)
@@ -316,7 +316,7 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct sta_info *psta)
        struct  sta_priv *pstapriv = &padapter->stapriv;
        struct hw_xmit *phwxmit;
 
-       if (psta == NULL)
+       if (!psta)
                goto exit;
 
 
@@ -520,7 +520,7 @@ struct sta_info *rtw_get_stainfo(struct sta_priv *pstapriv, u8 *hwaddr)
        u8 *addr;
        u8 bc_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
 
-       if (hwaddr == NULL)
+       if (!hwaddr)
                return NULL;
 
        if (IS_MCAST(hwaddr))
@@ -565,7 +565,7 @@ u32 rtw_init_bcmc_stainfo(struct adapter *padapter)
 
        psta = rtw_alloc_stainfo(pstapriv, bcast_addr);
 
-       if (psta == NULL) {
+       if (!psta) {
                res = _FAIL;
                RT_TRACE(_module_rtl871x_sta_mgt_c_, _drv_err_, ("rtw_alloc_stainfo fail"));
                goto exit;