Staging: xgifb: Refactor XGI_GetCRT2ResInfo().
authorMiguel Gómez <magomez@igalia.com>
Fri, 6 Jul 2012 10:40:49 +0000 (12:40 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 Jul 2012 23:59:31 +0000 (16:59 -0700)
Use a goto to remove one level of indentation, fixing style warnings.

Signed-off-by: Miguel Gómez <magomez@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/xgifb/vb_setmode.c

index 9dfc2de..a7ba99f 100644 (file)
@@ -3263,46 +3263,47 @@ static void XGI_GetCRT2ResInfo(unsigned short ModeNo,
        if (modeflag & DoubleScanMode)
                yres *= 2;
 
-       if (pVBInfo->VBInfo & SetCRT2ToLCD) {
-               if (pVBInfo->IF_DEF_LVDS == 0) {
-                       if (pVBInfo->LCDResInfo == Panel_1600x1200) {
-                               if (!(pVBInfo->LCDInfo & XGI_LCDVESATiming)) {
-                                       if (yres == 1024)
-                                               yres = 1056;
-                               }
+       if (!(pVBInfo->VBInfo & SetCRT2ToLCD))
+               goto exit;
+
+       if (pVBInfo->IF_DEF_LVDS == 0) {
+               if (pVBInfo->LCDResInfo == Panel_1600x1200) {
+                       if (!(pVBInfo->LCDInfo & XGI_LCDVESATiming)) {
+                               if (yres == 1024)
+                                       yres = 1056;
                        }
+               }
 
-                       if (pVBInfo->LCDResInfo == Panel_1280x1024) {
-                               if (yres == 400)
-                                       yres = 405;
-                               else if (yres == 350)
-                                       yres = 360;
+               if (pVBInfo->LCDResInfo == Panel_1280x1024) {
+                       if (yres == 400)
+                               yres = 405;
+                       else if (yres == 350)
+                               yres = 360;
 
-                               if (pVBInfo->LCDInfo & XGI_LCDVESATiming) {
-                                       if (yres == 360)
-                                               yres = 375;
-                               }
+                       if (pVBInfo->LCDInfo & XGI_LCDVESATiming) {
+                               if (yres == 360)
+                                       yres = 375;
                        }
+               }
 
-                       if (pVBInfo->LCDResInfo == Panel_1024x768) {
-                               if (!(pVBInfo->LCDInfo & XGI_LCDVESATiming)) {
-                                       if (!(pVBInfo->LCDInfo
-                                                       & LCDNonExpanding)) {
-                                               if (yres == 350)
-                                                       yres = 357;
-                                               else if (yres == 400)
-                                                       yres = 420;
-                                               else if (yres == 480)
-                                                       yres = 525;
-                                       }
+               if (pVBInfo->LCDResInfo == Panel_1024x768) {
+                       if (!(pVBInfo->LCDInfo & XGI_LCDVESATiming)) {
+                               if (!(pVBInfo->LCDInfo & LCDNonExpanding)) {
+                                       if (yres == 350)
+                                               yres = 357;
+                                       else if (yres == 400)
+                                               yres = 420;
+                                       else if (yres == 480)
+                                               yres = 525;
                                }
                        }
                }
-
-               if (xres == 720)
-                       xres = 640;
        }
 
+       if (xres == 720)
+               xres = 640;
+
+exit:
        pVBInfo->VGAHDE = xres;
        pVBInfo->HDE = xres;
        pVBInfo->VGAVDE = yres;