wifi: iwlwifi: mei: fix compilation errors in rfkill()
authorGregory Greenman <gregory.greenman@intel.com>
Thu, 26 Jan 2023 22:28:21 +0000 (00:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:32:57 +0000 (09:32 +0100)
[ Upstream commit 9cbd5a8abca904441e36861e3a92961bec41d13f ]

The rfkill() callback was invoked with wrong parameters.
It was missed since MEI is defined now as depending on BROKEN.
Fix that.

Fixes: d288067ede4b ("wifi: iwlwifi: mei: avoid blocking sap messages handling due to rtnl lock")
Fixes: 5aa7ce31bd84 ("wifi: iwlwifi: mei: make sure ownership confirmed message is sent")
Fixes: 95170a46b7dd ("wifi: iwlwifi: mei: don't send SAP commands if AMT is disabled")
Link: https://lore.kernel.org/r/20230126222821.305122-2-gregory.greenman@intel.com
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/intel/iwlwifi/mei/main.c

index c014209..27eb282 100644 (file)
@@ -784,7 +784,7 @@ static void iwl_mei_handle_amt_state(struct mei_cl_device *cldev,
        if (mei->amt_enabled)
                iwl_mei_set_init_conf(mei);
        else if (iwl_mei_cache.ops)
-               iwl_mei_cache.ops->rfkill(iwl_mei_cache.priv, false, false);
+               iwl_mei_cache.ops->rfkill(iwl_mei_cache.priv, false);
 
        schedule_work(&mei->netdev_work);
 
@@ -825,7 +825,7 @@ static void iwl_mei_handle_csme_taking_ownership(struct mei_cl_device *cldev,
                 */
                mei->csme_taking_ownership = true;
 
-               iwl_mei_cache.ops->rfkill(iwl_mei_cache.priv, true, true);
+               iwl_mei_cache.ops->rfkill(iwl_mei_cache.priv, true);
        } else {
                iwl_mei_send_sap_msg(cldev,
                                     SAP_MSG_NOTIF_CSME_OWNERSHIP_CONFIRMED);
@@ -1695,7 +1695,7 @@ int iwl_mei_register(void *priv, const struct iwl_mei_ops *ops)
                        if (mei->amt_enabled)
                                iwl_mei_send_sap_msg(mei->cldev,
                                                     SAP_MSG_NOTIF_WIFIDR_UP);
-                       ops->rfkill(priv, mei->link_prot_state, false);
+                       ops->rfkill(priv, mei->link_prot_state);
                }
        }
        ret = 0;