tools: image-host.c: use correct output format
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Thu, 8 Oct 2020 18:51:24 +0000 (20:51 +0200)
committerTom Rini <trini@konsulko.com>
Thu, 22 Oct 2020 13:54:54 +0000 (09:54 -0400)
When building on a 32bit host the following warning occurs:

tools/image-host.c: In function ‘fit_image_read_data’:
tools/image-host.c:296:56: warning: format ‘%ld’ expects argument of
type ‘long int’, but argument 3 has type ‘__off64_t’
{aka ‘long long int’} [-Wformat=]
   printf("File %s don't have the expected size (size=%ld, expected=%d)\n",
                                                      ~~^
                                                      %lld
          filename, sbuf.st_size, expected_size);
                    ~~~~~~~~~~~~
tools/image-host.c:311:62: warning: format ‘%ld’ expects argument of
type ‘long int’, but argument 4 has type ‘__off64_t’
{aka ‘long long int’} [-Wformat=]
   printf("Can't read all file %s (read %zd bytes, expexted %ld)\n",
                                                            ~~^
                                                            %lld
          filename, n, sbuf.st_size);
                       ~~~~~~~~~~~~

Fix the format strings.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
tools/image-host.c

index 8886bef..7cef78e 100644 (file)
@@ -293,8 +293,8 @@ static int fit_image_read_data(char *filename, unsigned char *data,
 
        /* Check file size */
        if (sbuf.st_size != expected_size) {
-               printf("File %s don't have the expected size (size=%ld, expected=%d)\n",
-                      filename, sbuf.st_size, expected_size);
+               printf("File %s don't have the expected size (size=%lld, expected=%d)\n",
+                      filename, (long long)sbuf.st_size, expected_size);
                goto err;
        }
 
@@ -308,8 +308,8 @@ static int fit_image_read_data(char *filename, unsigned char *data,
 
        /* Check that we have read all the file */
        if (n != sbuf.st_size) {
-               printf("Can't read all file %s (read %zd bytes, expexted %ld)\n",
-                      filename, n, sbuf.st_size);
+               printf("Can't read all file %s (read %zd bytes, expexted %lld)\n",
+                      filename, n, (long long)sbuf.st_size);
                goto err;
        }