x86/platform/intel-mid: Make several arrays static, to make code smaller
authorColin Ian King <colin.king@canonical.com>
Fri, 25 Aug 2017 16:32:06 +0000 (17:32 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 29 Aug 2017 11:30:16 +0000 (13:30 +0200)
Don't populate arrays on the stack, instead make them static.
Makes the object code smaller by 76 bytes:

Before:
   text    data     bss     dec     hex filename
   4217    1540     128    5885    16fd arch/x86/platform/intel-mid/pwr.o

After:
   text    data     bss     dec     hex filename
   3981    1700     128    5809    16b1 arch/x86/platform/intel-mid/pwr.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/20170825163206.23250-1-colin.king@canonical.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/platform/intel-mid/pwr.c

index ef03852..49ec5b9 100644 (file)
@@ -444,7 +444,7 @@ static int mid_set_initial_state(struct mid_pwr *pwr, const u32 *states)
 static int pnw_set_initial_state(struct mid_pwr *pwr)
 {
        /* On Penwell SRAM must stay powered on */
-       const u32 states[] = {
+       static const u32 states[] = {
                0xf00fffff,             /* PM_SSC(0) */
                0xffffffff,             /* PM_SSC(1) */
                0xffffffff,             /* PM_SSC(2) */
@@ -455,7 +455,7 @@ static int pnw_set_initial_state(struct mid_pwr *pwr)
 
 static int tng_set_initial_state(struct mid_pwr *pwr)
 {
-       const u32 states[] = {
+       static const u32 states[] = {
                0xffffffff,             /* PM_SSC(0) */
                0xffffffff,             /* PM_SSC(1) */
                0xffffffff,             /* PM_SSC(2) */