kselftest/arm64: Fix typo in hwcap check
authorMark Brown <broonie@kernel.org>
Wed, 7 Sep 2022 11:33:59 +0000 (12:33 +0100)
committerCatalin Marinas <catalin.marinas@arm.com>
Thu, 22 Sep 2022 19:52:06 +0000 (20:52 +0100)
We use a local variable hwcap to refer to the element of the hwcaps array
which we are currently checking. When checking for the relevant hwcap bit
being set in testing we were dereferencing hwcaps rather than hwcap in
fetching the AT_HWCAP to use, which is perfectly valid C but means we were
always checking the bit was set in the hwcap for whichever feature is first
in the array. Remove the stray s.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20220907113400.12982-1-broonie@kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
tools/testing/selftests/arm64/abi/hwcap.c

index d173e41..9f1a7b5 100644 (file)
@@ -295,7 +295,7 @@ int main(void)
        for (i = 0; i < ARRAY_SIZE(hwcaps); i++) {
                hwcap = &hwcaps[i];
 
-               have_hwcap = getauxval(hwcaps->at_hwcap) & hwcap->hwcap_bit;
+               have_hwcap = getauxval(hwcap->at_hwcap) & hwcap->hwcap_bit;
                have_cpuinfo = cpuinfo_present(hwcap->cpuinfo);
 
                if (have_hwcap)