ASoC: amd: Use platform_get_irq_byname() to get the interrupt
authorMeng Tang <tangmeng@uniontech.com>
Fri, 25 Feb 2022 11:23:58 +0000 (19:23 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 25 Feb 2022 13:45:37 +0000 (13:45 +0000)
platform_get_resource_byname(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq_byname().

Signed-off-by: Meng Tang <tangmeng@uniontech.com>
Link: https://lore.kernel.org/r/20220225112358.19403-1-tangmeng@uniontech.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp-renoir.c

index 35d66454e5a30fcb3895cd2cb3eb4b0b07847149..738cf2e2b973dcb74cf129e402e573a5c6e968bc 100644 (file)
@@ -282,13 +282,10 @@ static int renoir_audio_probe(struct platform_device *pdev)
        if (!adata->acp_base)
                return -ENOMEM;
 
-       res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "acp_dai_irq");
-       if (!res) {
-               dev_err(&pdev->dev, "IORESOURCE_IRQ FAILED\n");
+       adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq");
+       if (adata->i2s_irq < 0)
                return -ENODEV;
-       }
 
-       adata->i2s_irq = res->start;
        adata->dev = dev;
        adata->dai_driver = acp_renoir_dai;
        adata->num_dai = ARRAY_SIZE(acp_renoir_dai);