staging: vc04_services: bcm2835-camera: Remove unnecessary variable
authorNarcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
Wed, 1 Mar 2017 15:37:27 +0000 (17:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Mar 2017 12:57:17 +0000 (13:57 +0100)
Instead of storing the result, make the function return directly

Signed-off-by: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c

index 53e275e..84650d9 100644 (file)
@@ -671,7 +671,6 @@ static struct vb2_ops bm2835_mmal_video_qops = {
 static int set_overlay_params(struct bm2835_mmal_dev *dev,
                              struct vchiq_mmal_port *port)
 {
-       int ret;
        struct mmal_parameter_displayregion prev_config = {
        .set = MMAL_DISPLAY_SET_LAYER | MMAL_DISPLAY_SET_ALPHA |
            MMAL_DISPLAY_SET_DEST_RECT | MMAL_DISPLAY_SET_FULLSCREEN,
@@ -685,11 +684,9 @@ static int set_overlay_params(struct bm2835_mmal_dev *dev,
                      .height = dev->overlay.w.height,
                      },
        };
-       ret = vchiq_mmal_port_parameter_set(dev->instance, port,
-                                           MMAL_PARAMETER_DISPLAYREGION,
-                                           &prev_config, sizeof(prev_config));
-
-       return ret;
+       return vchiq_mmal_port_parameter_set(dev->instance, port,
+                                            MMAL_PARAMETER_DISPLAYREGION,
+                                            &prev_config, sizeof(prev_config));
 }
 
 /* overlay ioctl */