Directly use OperatorProperties where possible instead.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22967 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/compiler/graph-builder.cc b/src/compiler/graph-builder.cc
index fe55196..e8345ac 100644 (file)
--- a/src/compiler/graph-builder.cc
+++ b/src/compiler/graph-builder.cc
@@ -62,7 +62,7 @@ Node* StructuredGraphBuilder::MakeNode(Operator* op, int value_input_count,
     if (has_effect) {
       environment_->UpdateEffectDependency(result);
     }
-    if (NodeProperties::HasControlOutput(result) &&
+    if (OperatorProperties::HasControlOutput(result->op()) &&
         !environment_internal()->IsMarkedAsUnreachable()) {
       UpdateControlDependency(result);
     }
@@ -184,7 +184,7 @@ Node* StructuredGraphBuilder::NewEffectPhi(int count, Node* input,
 
 
 Node* StructuredGraphBuilder::MergeControl(Node* control, Node* other) {
-  int inputs = NodeProperties::GetControlInputCount(control) + 1;
+  int inputs = OperatorProperties::GetControlInputCount(control->op()) + 1;
   if (control->opcode() == IrOpcode::kLoop) {
     // Control node for loop exists, add input.
     Operator* op = common()->Loop(inputs);
@@ -206,7 +206,7 @@ Node* StructuredGraphBuilder::MergeControl(Node* control, Node* other) {
 
 Node* StructuredGraphBuilder::MergeEffect(Node* value, Node* other,
                                           Node* control) {
-  int inputs = NodeProperties::GetControlInputCount(control);
+  int inputs = OperatorProperties::GetControlInputCount(control->op());
   if (value->opcode() == IrOpcode::kEffectPhi &&
       NodeProperties::GetControlInput(value) == control) {
     // Phi already exists, add input.
@@ -223,7 +223,7 @@ Node* StructuredGraphBuilder::MergeEffect(Node* value, Node* other,
 
 Node* StructuredGraphBuilder::MergeValue(Node* value, Node* other,
                                          Node* control) {
-  int inputs = NodeProperties::GetControlInputCount(control);
+  int inputs = OperatorProperties::GetControlInputCount(control->op());
   if (value->opcode() == IrOpcode::kPhi &&
       NodeProperties::GetControlInput(value) == control) {
     // Phi already exists, add input.

diff --git a/src/compiler/graph-visualizer.cc b/src/compiler/graph-visualizer.cc
index 032d3d9..144512a 100644 (file)
--- a/src/compiler/graph-visualizer.cc
+++ b/src/compiler/graph-visualizer.cc
@@ -46,11 +46,12 @@ class GraphVisualizer : public NullNodeVisitor {
 
 
 static Node* GetControlCluster(Node* node) {
-  if (NodeProperties::IsBasicBlockBegin(node)) {
+  if (OperatorProperties::IsBasicBlockBegin(node->op())) {
     return node;
-  } else if (NodeProperties::GetControlInputCount(node) == 1) {
+  } else if (OperatorProperties::GetControlInputCount(node->op()) == 1) {
     Node* control = NodeProperties::GetControlInput(node, 0);
-    return NodeProperties::IsBasicBlockBegin(control) ? control : NULL;
+    return OperatorProperties::IsBasicBlockBegin(control->op()) ? control
+                                                                : NULL;
   } else {
     return NULL;
   }
@@ -156,19 +157,23 @@ void GraphVisualizer::AnnotateNode(Node* node) {
   os_ << "    label=\"{{#" << node->id() << ":" << Escaped(label);
 
   InputIter i = node->inputs().begin();
-  for (int j = NodeProperties::GetValueInputCount(node); j > 0; ++i, j--) {
+  for (int j = OperatorProperties::GetValueInputCount(node->op()); j > 0;
+       ++i, j--) {
     os_ << "|<I" << i.index() << ">#" << (*i)->id();
   }
-  for (int j = NodeProperties::GetContextInputCount(node); j > 0; ++i, j--) {
+  for (int j = OperatorProperties::GetContextInputCount(node->op()); j > 0;
+       ++i, j--) {
     os_ << "|<I" << i.index() << ">X #" << (*i)->id();
   }
-  for (int j = NodeProperties::GetEffectInputCount(node); j > 0; ++i, j--) {
+  for (int j = OperatorProperties::GetEffectInputCount(node->op()); j > 0;
+       ++i, j--) {
     os_ << "|<I" << i.index() << ">E #" << (*i)->id();
   }
 
-  if (!use_to_def_ || NodeProperties::IsBasicBlockBegin(node) ||
+  if (!use_to_def_ || OperatorProperties::IsBasicBlockBegin(node->op()) ||
       GetControlCluster(node) == NULL) {
-    for (int j = NodeProperties::GetControlInputCount(node); j > 0; ++i, j--) {
+    for (int j = OperatorProperties::GetControlInputCount(node->op()); j > 0;
+         ++i, j--) {
       os_ << "|<I" << i.index() << ">C #" << (*i)->id();
     }
   }
@@ -191,9 +196,9 @@ void GraphVisualizer::PrintEdge(Node* from, int index, Node* to) {
   os_ << "  ID" << from->id();
   if (all_nodes_.count(to) == 0) {
     os_ << ":I" << index << ":n -> DEAD_INPUT";
-  } else if (NodeProperties::IsBasicBlockBegin(from) ||
+  } else if (OperatorProperties::IsBasicBlockBegin(from->op()) ||
              GetControlCluster(from) == NULL ||
-             (NodeProperties::GetControlInputCount(from) > 0 &&
+             (OperatorProperties::GetControlInputCount(from->op()) > 0 &&
               NodeProperties::GetControlInput(from) != to)) {
     os_ << ":I" << index << ":n -> ID" << to->id() << ":s";
     if (unconstrained) os_ << " [constraint=false,style=dotted]";

diff --git a/src/compiler/instruction-selector.cc b/src/compiler/instruction-selector.cc
index 12833fb..a8d5377 100644 (file)
--- a/src/compiler/instruction-selector.cc
+++ b/src/compiler/instruction-selector.cc
@@ -266,7 +266,8 @@ void InstructionSelector::InitializeCallBuffer(Node* call, CallBuffer* buffer,
                                                BasicBlock* deopt_node) {
   OperandGenerator g(this);
   DCHECK_EQ(call->op()->OutputCount(), buffer->descriptor->ReturnCount());
-  DCHECK_EQ(NodeProperties::GetValueInputCount(call), buffer->input_count());
+  DCHECK_EQ(OperatorProperties::GetValueInputCount(call->op()),
+            buffer->input_count());
 
   if (buffer->descriptor->ReturnCount() > 0) {
     // Collect the projections that represent multiple outputs from this call.

diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc
index 043722f..fe4fe65 100644 (file)
--- a/src/compiler/js-generic-lowering.cc
+++ b/src/compiler/js-generic-lowering.cc
@@ -356,7 +356,7 @@ void JSGenericLowering::ReplaceWithRuntimeCall(Node* node,
   const Runtime::Function* fun = Runtime::FunctionForId(f);
   int nargs = (nargs_override < 0) ? fun->nargs : nargs_override;
   CallDescriptor::DeoptimizationSupport deopt =
-      NodeProperties::CanLazilyDeoptimize(node)
+      OperatorProperties::CanLazilyDeoptimize(node->op())
           ? CallDescriptor::kCanDeoptimize
           : CallDescriptor::kCannotDeoptimize;
   CallDescriptor* desc =
@@ -554,7 +554,7 @@ Node* JSGenericLowering::LowerJSCallFunction(Node* node) {
 
 Node* JSGenericLowering::LowerJSCallRuntime(Node* node) {
   Runtime::FunctionId function = OpParameter<Runtime::FunctionId>(node);
-  int arity = NodeProperties::GetValueInputCount(node);
+  int arity = OperatorProperties::GetValueInputCount(node->op());
   ReplaceWithRuntimeCall(node, function, arity);
   return node;
 }

diff --git a/src/compiler/node-properties-inl.h b/src/compiler/node-properties-inl.h
index 8c80945..ea58b4d 100644 (file)
--- a/src/compiler/node-properties-inl.h
+++ b/src/compiler/node-properties-inl.h
@@ -19,49 +19,15 @@ namespace internal {
 namespace compiler {
 
 // -----------------------------------------------------------------------------
-// Input counts & layout.
+// Input layout.
 // Inputs are always arranged in order as follows:
 //     0 [ values, context, effects, control ] node->InputCount()
 
-inline bool NodeProperties::HasValueInput(Node* node) {
-  return OperatorProperties::HasValueInput(node->op());
-}
-
-inline bool NodeProperties::HasContextInput(Node* node) {
-  return OperatorProperties::HasContextInput(node->op());
-}
-
-inline bool NodeProperties::HasEffectInput(Node* node) {
-  return OperatorProperties::HasEffectInput(node->op());
-}
-
-inline bool NodeProperties::HasControlInput(Node* node) {
-  return OperatorProperties::HasControlInput(node->op());
-}
-
-
-inline int NodeProperties::GetValueInputCount(Node* node) {
-  return OperatorProperties::GetValueInputCount(node->op());
-}
-
-inline int NodeProperties::GetContextInputCount(Node* node) {
-  return OperatorProperties::GetContextInputCount(node->op());
-}
-
-inline int NodeProperties::GetEffectInputCount(Node* node) {
-  return OperatorProperties::GetEffectInputCount(node->op());
-}
-
-inline int NodeProperties::GetControlInputCount(Node* node) {
-  return OperatorProperties::GetControlInputCount(node->op());
-}
-
 
 inline int NodeProperties::GetContextIndex(Node* node) {
   return PastValueIndex(node);
 }
 
-
 inline int NodeProperties::FirstValueIndex(Node* node) { return 0; }
 
 inline int NodeProperties::FirstEffectIndex(Node* node) {
@@ -74,19 +40,23 @@ inline int NodeProperties::FirstControlIndex(Node* node) {
 
 
 inline int NodeProperties::PastValueIndex(Node* node) {
-  return FirstValueIndex(node) + GetValueInputCount(node);
+  return FirstValueIndex(node) +
+         OperatorProperties::GetValueInputCount(node->op());
 }
 
 inline int NodeProperties::PastContextIndex(Node* node) {
-  return GetContextIndex(node) + GetContextInputCount(node);
+  return GetContextIndex(node) +
+         OperatorProperties::GetContextInputCount(node->op());
 }
 
 inline int NodeProperties::PastEffectIndex(Node* node) {
-  return FirstEffectIndex(node) + GetEffectInputCount(node);
+  return FirstEffectIndex(node) +
+         OperatorProperties::GetEffectInputCount(node->op());
 }
 
 inline int NodeProperties::PastControlIndex(Node* node) {
-  return FirstControlIndex(node) + GetControlInputCount(node);
+  return FirstControlIndex(node) +
+         OperatorProperties::GetControlInputCount(node->op());
 }
 
 
@@ -94,56 +64,30 @@ inline int NodeProperties::PastControlIndex(Node* node) {
 // Input accessors.
 
 inline Node* NodeProperties::GetValueInput(Node* node, int index) {
-  DCHECK(0 <= index && index < GetValueInputCount(node));
+  DCHECK(0 <= index &&
+         index < OperatorProperties::GetValueInputCount(node->op()));
   return node->InputAt(FirstValueIndex(node) + index);
 }
 
 inline Node* NodeProperties::GetContextInput(Node* node) {
-  DCHECK(HasContextInput(node));
+  DCHECK(OperatorProperties::HasContextInput(node->op()));
   return node->InputAt(GetContextIndex(node));
 }
 
 inline Node* NodeProperties::GetEffectInput(Node* node, int index) {
-  DCHECK(0 <= index && index < GetEffectInputCount(node));
+  DCHECK(0 <= index &&
+         index < OperatorProperties::GetEffectInputCount(node->op()));
   return node->InputAt(FirstEffectIndex(node) + index);
 }
 
 inline Node* NodeProperties::GetControlInput(Node* node, int index) {
-  DCHECK(0 <= index && index < GetControlInputCount(node));
+  DCHECK(0 <= index &&
+         index < OperatorProperties::GetControlInputCount(node->op()));
   return node->InputAt(FirstControlIndex(node) + index);
 }
 
 
 // -----------------------------------------------------------------------------
-// Output counts.
-
-inline bool NodeProperties::HasValueOutput(Node* node) {
-  return OperatorProperties::HasValueOutput(node->op());
-}
-
-inline bool NodeProperties::HasEffectOutput(Node* node) {
-  return OperatorProperties::HasEffectOutput(node->op());
-}
-
-inline bool NodeProperties::HasControlOutput(Node* node) {
-  return OperatorProperties::HasControlOutput(node->op());
-}
-
-
-inline int NodeProperties::GetValueOutputCount(Node* node) {
-  return OperatorProperties::GetValueOutputCount(node->op());
-}
-
-inline int NodeProperties::GetEffectOutputCount(Node* node) {
-  return OperatorProperties::GetEffectOutputCount(node->op());
-}
-
-inline int NodeProperties::GetControlOutputCount(Node* node) {
-  return OperatorProperties::GetControlOutputCount(node->op());
-}
-
-
-// -----------------------------------------------------------------------------
 // Edge kinds.
 
 inline bool NodeProperties::IsInputRange(Node::Edge edge, int first, int num) {
@@ -156,23 +100,26 @@ inline bool NodeProperties::IsInputRange(Node::Edge edge, int first, int num) {
 
 inline bool NodeProperties::IsValueEdge(Node::Edge edge) {
   Node* node = edge.from();
-  return IsInputRange(edge, FirstValueIndex(node), GetValueInputCount(node));
+  return IsInputRange(edge, FirstValueIndex(node),
+                      OperatorProperties::GetValueInputCount(node->op()));
 }
 
 inline bool NodeProperties::IsContextEdge(Node::Edge edge) {
   Node* node = edge.from();
-  return IsInputRange(edge, GetContextIndex(node), GetContextInputCount(node));
+  return IsInputRange(edge, GetContextIndex(node),
+                      OperatorProperties::GetContextInputCount(node->op()));
 }
 
 inline bool NodeProperties::IsEffectEdge(Node::Edge edge) {
   Node* node = edge.from();
-  return IsInputRange(edge, FirstEffectIndex(node), GetEffectInputCount(node));
+  return IsInputRange(edge, FirstEffectIndex(node),
+                      OperatorProperties::GetEffectInputCount(node->op()));
 }
 
 inline bool NodeProperties::IsControlEdge(Node::Edge edge) {
   Node* node = edge.from();
   return IsInputRange(edge, FirstControlIndex(node),
-                      GetControlInputCount(node));
+                      OperatorProperties::GetControlInputCount(node->op()));
 }
 
 
@@ -183,35 +130,21 @@ inline bool NodeProperties::IsControl(Node* node) {
   return IrOpcode::IsControlOpcode(node->opcode());
 }
 
-inline bool NodeProperties::IsBasicBlockBegin(Node* node) {
-  return OperatorProperties::IsBasicBlockBegin(node->op());
-}
-
-inline bool NodeProperties::CanBeScheduled(Node* node) {
-  return OperatorProperties::CanBeScheduled(node->op());
-}
-
-inline bool NodeProperties::HasFixedSchedulePosition(Node* node) {
-  return OperatorProperties::HasFixedSchedulePosition(node->op());
-}
-
-inline bool NodeProperties::IsScheduleRoot(Node* node) {
-  return OperatorProperties::IsScheduleRoot(node->op());
-}
-
 
 // -----------------------------------------------------------------------------
 // Miscellaneous mutators.
 
 inline void NodeProperties::ReplaceEffectInput(Node* node, Node* effect,
                                                int index) {
-  DCHECK(index < GetEffectInputCount(node));
+  DCHECK(index < OperatorProperties::GetEffectInputCount(node->op()));
   return node->ReplaceInput(
-      GetValueInputCount(node) + GetContextInputCount(node) + index, effect);
+      OperatorProperties::GetValueInputCount(node->op()) +
+          OperatorProperties::GetContextInputCount(node->op()) + index,
+      effect);
 }
 
 inline void NodeProperties::RemoveNonValueInputs(Node* node) {
-  node->TrimInputCount(GetValueInputCount(node));
+  node->TrimInputCount(OperatorProperties::GetValueInputCount(node->op()));
 }
 
 
@@ -225,9 +158,6 @@ inline void NodeProperties::SetBounds(Node* node, Bounds b) {
 }
 
 
-inline bool NodeProperties::CanLazilyDeoptimize(Node* node) {
-  return OperatorProperties::CanLazilyDeoptimize(node->op());
-}
 }
 }
 }  // namespace v8::internal::compiler

diff --git a/src/compiler/node-properties.h b/src/compiler/node-properties.h
index 5a1348c..001bd02 100644 (file)
--- a/src/compiler/node-properties.h
+++ b/src/compiler/node-properties.h
@@ -19,41 +19,17 @@ class Operator;
 // A facade that simplifies access to the different kinds of inputs to a node.
 class NodeProperties {
  public:
-  static inline bool HasValueInput(Node* node);
-  static inline bool HasContextInput(Node* node);
-  static inline bool HasEffectInput(Node* node);
-  static inline bool HasControlInput(Node* node);
-
-  static inline int GetValueInputCount(Node* node);
-  static inline int GetContextInputCount(Node* node);
-  static inline int GetEffectInputCount(Node* node);
-  static inline int GetControlInputCount(Node* node);
-  static inline int GetTotalInputCount(Node* node);
-
   static inline Node* GetValueInput(Node* node, int index);
   static inline Node* GetContextInput(Node* node);
   static inline Node* GetEffectInput(Node* node, int index = 0);
   static inline Node* GetControlInput(Node* node, int index = 0);
 
-  static inline bool HasValueOutput(Node* node);
-  static inline bool HasEffectOutput(Node* node);
-  static inline bool HasControlOutput(Node* node);
-
-  static inline int GetValueOutputCount(Node* node);
-  static inline int GetEffectOutputCount(Node* node);
-  static inline int GetControlOutputCount(Node* node);
-
   static inline bool IsValueEdge(Node::Edge edge);
   static inline bool IsContextEdge(Node::Edge edge);
   static inline bool IsEffectEdge(Node::Edge edge);
   static inline bool IsControlEdge(Node::Edge edge);
 
   static inline bool IsControl(Node* node);
-  static inline bool IsBasicBlockBegin(Node* node);
-
-  static inline bool CanBeScheduled(Node* node);
-  static inline bool HasFixedSchedulePosition(Node* node);
-  static inline bool IsScheduleRoot(Node* node);
 
   static inline void ReplaceEffectInput(Node* node, Node* effect,
                                         int index = 0);
@@ -62,8 +38,6 @@ class NodeProperties {
   static inline Bounds GetBounds(Node* node);
   static inline void SetBounds(Node* node, Bounds bounds);
 
-  static inline bool CanLazilyDeoptimize(Node* node);
-
   static inline int GetContextIndex(Node* node);
 
  private:

diff --git a/src/compiler/scheduler.cc b/src/compiler/scheduler.cc
index ad95da5..be2c4d9 100644 (file)
--- a/src/compiler/scheduler.cc
+++ b/src/compiler/scheduler.cc
@@ -105,7 +105,7 @@ class CreateBlockVisitor : public NullNodeVisitor {
         break;
       }
       case IrOpcode::kCall: {
-        if (NodeProperties::CanLazilyDeoptimize(node)) {
+        if (OperatorProperties::CanLazilyDeoptimize(node->op())) {
           scheduler_->calls_.push_back(node);
         }
         break;
@@ -171,7 +171,7 @@ void Scheduler::AddPredecessorsForLoopsAndMerges() {
     // For all of the merge's control inputs, add a goto at the end to the
     // merge's basic block.
     for (InputIter j = (*i)->inputs().begin(); j != (*i)->inputs().end(); ++j) {
-      if (NodeProperties::IsBasicBlockBegin(*i)) {
+      if (OperatorProperties::IsBasicBlockBegin((*i)->op())) {
         BasicBlock* predecessor_block = schedule_->block(*j);
         if ((*j)->opcode() != IrOpcode::kReturn &&
             (*j)->opcode() != IrOpcode::kDeoptimize) {
@@ -194,7 +194,7 @@ void Scheduler::AddSuccessorsForCalls() {
   for (NodeVectorIter i = calls_.begin(); i != calls_.end(); ++i) {
     Node* call = *i;
     DCHECK(call->opcode() == IrOpcode::kCall);
-    DCHECK(NodeProperties::CanLazilyDeoptimize(call));
+    DCHECK(OperatorProperties::CanLazilyDeoptimize(call->op()));
 
     Node* lazy_deopt_node = NULL;
     Node* cont_node = NULL;
@@ -389,7 +389,7 @@ class ScheduleEarlyNodeVisitor : public NullNodeVisitor {
     int max_rpo = 0;
     // Otherwise, the minimum rpo for the node is the max of all of the inputs.
     if (!IsFixedNode(node)) {
-      DCHECK(!NodeProperties::IsBasicBlockBegin(node));
+      DCHECK(!OperatorProperties::IsBasicBlockBegin(node->op()));
       for (InputIter i = node->inputs().begin(); i != node->inputs().end();
            ++i) {
         int control_rpo = scheduler_->schedule_early_rpo_index_[(*i)->id()];
@@ -409,8 +409,8 @@ class ScheduleEarlyNodeVisitor : public NullNodeVisitor {
   }
 
   static bool IsFixedNode(Node* node) {
-    return NodeProperties::HasFixedSchedulePosition(node) ||
-           !NodeProperties::CanBeScheduled(node);
+    return OperatorProperties::HasFixedSchedulePosition(node->op()) ||
+           !OperatorProperties::CanBeScheduled(node->op());
   }
 
   // TODO(mstarzinger): Dirty hack to unblock others, schedule early should be
@@ -452,7 +452,7 @@ class PrepareUsesVisitor : public NullNodeVisitor {
     // right place; it's a convenient place during the preparation of use counts
     // to schedule them.
     if (!schedule_->IsScheduled(node) &&
-        NodeProperties::HasFixedSchedulePosition(node)) {
+        OperatorProperties::HasFixedSchedulePosition(node->op())) {
       if (FLAG_trace_turbo_scheduler) {
         PrintF("Fixed position node %d is unscheduled, scheduling now\n",
                node->id());
@@ -466,7 +466,7 @@ class PrepareUsesVisitor : public NullNodeVisitor {
       schedule_->AddNode(block, node);
     }
 
-    if (NodeProperties::IsScheduleRoot(node)) {
+    if (OperatorProperties::IsScheduleRoot(node->op())) {
       scheduler_->schedule_root_nodes_.push_back(node);
     }
 
@@ -477,8 +477,9 @@ class PrepareUsesVisitor : public NullNodeVisitor {
     // If the edge is from an unscheduled node, then tally it in the use count
     // for all of its inputs. The same criterion will be used in ScheduleLate
     // for decrementing use counts.
-    if (!schedule_->IsScheduled(from) && NodeProperties::CanBeScheduled(from)) {
-      DCHECK(!NodeProperties::HasFixedSchedulePosition(from));
+    if (!schedule_->IsScheduled(from) &&
+        OperatorProperties::CanBeScheduled(from->op())) {
+      DCHECK(!OperatorProperties::HasFixedSchedulePosition(from->op()));
       ++scheduler_->unscheduled_uses_[to->id()];
       if (FLAG_trace_turbo_scheduler) {
         PrintF("Incrementing uses of node %d from %d to %d\n", to->id(),
@@ -511,10 +512,11 @@ class ScheduleLateNodeVisitor : public NullNodeVisitor {
 
   GenericGraphVisit::Control Pre(Node* node) {
     // Don't schedule nodes that cannot be scheduled or are already scheduled.
-    if (!NodeProperties::CanBeScheduled(node) || schedule_->IsScheduled(node)) {
+    if (!OperatorProperties::CanBeScheduled(node->op()) ||
+        schedule_->IsScheduled(node)) {
       return GenericGraphVisit::CONTINUE;
     }
-    DCHECK(!NodeProperties::HasFixedSchedulePosition(node));
+    DCHECK(!OperatorProperties::HasFixedSchedulePosition(node->op()));
 
     // If all the uses of a node have been scheduled, then the node itself can
     // be scheduled.

diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index 32a1120..2aa1869 100644 (file)
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -253,7 +253,7 @@ Bounds Typer::Visitor::TypeExternalConstant(Node* node) {
 
 
 Bounds Typer::Visitor::TypePhi(Node* node) {
-  int arity = NodeProperties::GetValueInputCount(node);
+  int arity = OperatorProperties::GetValueInputCount(node->op());
   Bounds bounds = OperandType(node, 0);
   for (int i = 1; i < arity; ++i) {
     bounds = Bounds::Either(bounds, OperandType(node, i), zone());

diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 1525490..97bb762 100644 (file)
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -56,10 +56,10 @@ class Verifier::Visitor : public NullNodeVisitor {
 
 
 GenericGraphVisit::Control Verifier::Visitor::Pre(Node* node) {
-  int value_count = NodeProperties::GetValueInputCount(node);
-  int context_count = NodeProperties::GetContextInputCount(node);
-  int effect_count = NodeProperties::GetEffectInputCount(node);
-  int control_count = NodeProperties::GetControlInputCount(node);
+  int value_count = OperatorProperties::GetValueInputCount(node->op());
+  int context_count = OperatorProperties::GetContextInputCount(node->op());
+  int effect_count = OperatorProperties::GetEffectInputCount(node->op());
+  int control_count = OperatorProperties::GetControlInputCount(node->op());
 
   // Verify number of inputs matches up.
   int input_count = value_count + context_count + effect_count + control_count;
@@ -68,7 +68,7 @@ GenericGraphVisit::Control Verifier::Visitor::Pre(Node* node) {
   // Verify all value inputs actually produce a value.
   for (int i = 0; i < value_count; ++i) {
     Node* value = NodeProperties::GetValueInput(node, i);
-    CHECK(NodeProperties::HasValueOutput(value));
+    CHECK(OperatorProperties::HasValueOutput(value->op()));
     CHECK(IsDefUseChainLinkPresent(value, node));
     CHECK(IsUseDefChainLinkPresent(value, node));
   }
@@ -76,7 +76,7 @@ GenericGraphVisit::Control Verifier::Visitor::Pre(Node* node) {
   // Verify all context inputs are value nodes.
   for (int i = 0; i < context_count; ++i) {
     Node* context = NodeProperties::GetContextInput(node);
-    CHECK(NodeProperties::HasValueOutput(context));
+    CHECK(OperatorProperties::HasValueOutput(context->op()));
     CHECK(IsDefUseChainLinkPresent(context, node));
     CHECK(IsUseDefChainLinkPresent(context, node));
   }
@@ -84,7 +84,7 @@ GenericGraphVisit::Control Verifier::Visitor::Pre(Node* node) {
   // Verify all effect inputs actually have an effect.
   for (int i = 0; i < effect_count; ++i) {
     Node* effect = NodeProperties::GetEffectInput(node);
-    CHECK(NodeProperties::HasEffectOutput(effect));
+    CHECK(OperatorProperties::HasEffectOutput(effect->op()));
     CHECK(IsDefUseChainLinkPresent(effect, node));
     CHECK(IsUseDefChainLinkPresent(effect, node));
   }
@@ -92,13 +92,13 @@ GenericGraphVisit::Control Verifier::Visitor::Pre(Node* node) {
   // Verify all control inputs are control nodes.
   for (int i = 0; i < control_count; ++i) {
     Node* control = NodeProperties::GetControlInput(node, i);
-    CHECK(NodeProperties::HasControlOutput(control));
+    CHECK(OperatorProperties::HasControlOutput(control->op()));
     CHECK(IsDefUseChainLinkPresent(control, node));
     CHECK(IsUseDefChainLinkPresent(control, node));
   }
 
   // Verify all successors are projections if multiple value outputs exist.
-  if (NodeProperties::GetValueOutputCount(node) > 1) {
+  if (OperatorProperties::GetValueOutputCount(node->op()) > 1) {
     Node::Uses uses = node->uses();
     for (Node::Uses::iterator it = uses.begin(); it != uses.end(); ++it) {
       CHECK(!NodeProperties::IsValueEdge(it.edge()) ||
@@ -114,9 +114,9 @@ GenericGraphVisit::Control Verifier::Visitor::Pre(Node* node) {
       break;
     case IrOpcode::kEnd:
       // End has no outputs.
-      CHECK(!NodeProperties::HasValueOutput(node));
-      CHECK(!NodeProperties::HasEffectOutput(node));
-      CHECK(!NodeProperties::HasControlOutput(node));
+      CHECK(!OperatorProperties::HasValueOutput(node->op()));
+      CHECK(!OperatorProperties::HasEffectOutput(node->op()));
+      CHECK(!OperatorProperties::HasControlOutput(node->op()));
       break;
     case IrOpcode::kDead:
       // Dead is never connected to the graph.
@@ -158,7 +158,7 @@ GenericGraphVisit::Control Verifier::Visitor::Pre(Node* node) {
       int index = static_cast<Operator1<int>*>(node->op())->parameter();
       Node* input = NodeProperties::GetValueInput(node, 0);
       // Currently, parameter indices start at -1 instead of 0.
-      CHECK_GT(NodeProperties::GetValueOutputCount(input), index + 1);
+      CHECK_GT(OperatorProperties::GetValueOutputCount(input->op()), index + 1);
       break;
     }
     case IrOpcode::kInt32Constant:
@@ -174,14 +174,16 @@ GenericGraphVisit::Control Verifier::Visitor::Pre(Node* node) {
       // Phi input count matches parent control node.
       CHECK_EQ(1, control_count);
       Node* control = NodeProperties::GetControlInput(node, 0);
-      CHECK_EQ(value_count, NodeProperties::GetControlInputCount(control));
+      CHECK_EQ(value_count,
+               OperatorProperties::GetControlInputCount(control->op()));
       break;
     }
     case IrOpcode::kEffectPhi: {
       // EffectPhi input count matches parent control node.
       CHECK_EQ(1, control_count);
       Node* control = NodeProperties::GetControlInput(node, 0);
-      CHECK_EQ(effect_count, NodeProperties::GetControlInputCount(control));
+      CHECK_EQ(effect_count,
+               OperatorProperties::GetControlInputCount(control->op()));
       break;
     }
     case IrOpcode::kLazyDeoptimization:
@@ -203,7 +205,7 @@ GenericGraphVisit::Control Verifier::Visitor::Pre(Node* node) {
       // Projection has an input that produces enough values.
       int index = static_cast<Operator1<int>*>(node->op())->parameter();
       Node* input = NodeProperties::GetValueInput(node, 0);
-      CHECK_GT(NodeProperties::GetValueOutputCount(input), index);
+      CHECK_GT(OperatorProperties::GetValueOutputCount(input->op()), index);
       break;
     }
     default:

diff --git a/test/cctest/compiler/test-js-typed-lowering.cc b/test/cctest/compiler/test-js-typed-lowering.cc
index 80f7089..b6aa6d9 100644 (file)
--- a/test/cctest/compiler/test-js-typed-lowering.cc
+++ b/test/cctest/compiler/test-js-typed-lowering.cc
@@ -861,9 +861,9 @@ class BinopEffectsTester {
   Node* CheckConverted(IrOpcode::Value opcode, Node* node, bool effects) {
     CHECK_EQ(opcode, node->opcode());
     if (effects) {
-      CHECK_LT(0, NodeProperties::GetEffectInputCount(node));
+      CHECK_LT(0, OperatorProperties::GetEffectInputCount(node->op()));
     } else {
-      CHECK_EQ(0, NodeProperties::GetEffectInputCount(node));
+      CHECK_EQ(0, OperatorProperties::GetEffectInputCount(node->op()));
     }
     return node;
   }