splitmuxsink: Only set running time on finalizing sink element when in async-finalize...
authorSebastian Dröge <sebastian@centricular.com>
Wed, 22 May 2019 15:06:04 +0000 (18:06 +0300)
committerSebastian Dröge <sebastian@centricular.com>
Tue, 28 May 2019 14:21:06 +0000 (17:21 +0300)
There is only a single sink element in async-finalize mode, and we would
keep the running time from previous fragments set in that case. As we
don't ever set the running time for the very last fragment on EOS, this
would mean that the closing time reported for the very last fragment is
the same as the closing time of the previous fragment.

gst/multifile/gstsplitmuxsink.c

index a9cd723..369ef25 100644 (file)
@@ -2026,10 +2026,12 @@ handle_gathered_gop (GstSplitMuxSink * splitmux)
   /* Check for overrun - have we output at least one byte and overrun
    * either threshold? */
   if (need_new_fragment (splitmux, queued_time, queued_gop_time, queued_bytes)) {
-    GstClockTime *sink_running_time = g_new (GstClockTime, 1);
-    *sink_running_time = splitmux->reference_ctx->out_running_time;
-    g_object_set_qdata_full (G_OBJECT (splitmux->sink),
-        RUNNING_TIME, sink_running_time, g_free);
+    if (splitmux->async_finalize) {
+      GstClockTime *sink_running_time = g_new (GstClockTime, 1);
+      *sink_running_time = splitmux->reference_ctx->out_running_time;
+      g_object_set_qdata_full (G_OBJECT (splitmux->sink),
+          RUNNING_TIME, sink_running_time, g_free);
+    }
     g_atomic_int_set (&(splitmux->do_split_next_gop), FALSE);
     /* Tell the output side to start a new fragment */
     GST_INFO_OBJECT (splitmux,