Fix IsSafeToContained. (#14268)
authorSergey Andreenko <seandree@microsoft.com>
Tue, 3 Oct 2017 20:38:02 +0000 (13:38 -0700)
committerGitHub <noreply@github.com>
Tue, 3 Oct 2017 20:38:02 +0000 (13:38 -0700)
When AliasSet adds a node, it should also add all its nodes that are
executed inside it (marked as contained).

src/jit/sideeffects.cpp
tests/issues.targets

index e87abd3..931ee6f 100644 (file)
@@ -263,6 +263,10 @@ void AliasSet::AddNode(Compiler* compiler, GenTree* node)
 
             m_lclVarReads.Add(compiler, lclNum);
         }
+        if (!operand->IsArgPlaceHolderNode() && operand->isContained())
+        {
+            AddNode(compiler, operand);
+        }
         return GenTree::VisitResult::Continue;
     });
 
index af76950..fce3f8a 100644 (file)
         <ExcludeList Include="$(XunitTestBinBase)\Loader\classloader\TypeGeneratorTests\TypeGeneratorTest683\Generated683\*">
             <Issue>6707</Issue>
         </ExcludeList>
-        <ExcludeList Include="$(XunitTestBinBase)\JIT\Regression\JitBlue\GitHub_13910\GitHub_13910\GitHub_13910.cmd">
-            <Issue>13910</Issue>
-        </ExcludeList>
     </ItemGroup>
 
     <!-- The following are x86 failures -->