ocxl: read_pasid never returns an error, so make it void
authorAlastair D'Silva <alastair@d-silva.org>
Mon, 25 Mar 2019 05:34:53 +0000 (16:34 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 2 May 2019 16:55:00 +0000 (02:55 +1000)
No need for a return value in read_pasid as it only returns 0.

Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
drivers/misc/ocxl/config.c

index 8f2c5d8..4dc1189 100644 (file)
@@ -68,7 +68,7 @@ static int find_dvsec_afu_ctrl(struct pci_dev *dev, u8 afu_idx)
        return 0;
 }
 
-static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn)
+static void read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn)
 {
        u16 val;
        int pos;
@@ -89,7 +89,6 @@ static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn)
 out:
        dev_dbg(&dev->dev, "PASID capability:\n");
        dev_dbg(&dev->dev, "  Max PASID log = %d\n", fn->max_pasid_log);
-       return 0;
 }
 
 static int read_dvsec_tl(struct pci_dev *dev, struct ocxl_fn_config *fn)
@@ -205,11 +204,7 @@ int ocxl_config_read_function(struct pci_dev *dev, struct ocxl_fn_config *fn)
 {
        int rc;
 
-       rc = read_pasid(dev, fn);
-       if (rc) {
-               dev_err(&dev->dev, "Invalid PASID configuration: %d\n", rc);
-               return -ENODEV;
-       }
+       read_pasid(dev, fn);
 
        rc = read_dvsec_tl(dev, fn);
        if (rc) {