Should override the virtual destructor.
authorHaojian Wu <hokein.wu@gmail.com>
Thu, 30 Mar 2017 21:13:23 +0000 (23:13 +0200)
committerHaojian Wu <hokein.wu@gmail.com>
Thu, 30 Mar 2017 21:19:43 +0000 (23:19 +0200)
atom/browser/net/atom_cert_verifier.cc
atom/browser/web_dialog_helper.cc

index 5dee107..2a2229f 100644 (file)
@@ -50,7 +50,7 @@ class CertVerifierRequest : public AtomCertVerifier::Request {
         first_response_(true),
         weak_ptr_factory_(this) {}
 
-  ~CertVerifierRequest() {
+  ~CertVerifierRequest() override {
     cert_verifier_->RemoveRequest(params_);
     default_verifier_request_.reset();
     while (!response_list_.empty() && !first_response_) {
index 448fccd..fcd598b 100644 (file)
@@ -51,7 +51,7 @@ class FileSelectHelper : public base::RefCounted<FileSelectHelper>,
  private:
   friend class base::RefCounted<FileSelectHelper>;
 
-  ~FileSelectHelper() {}
+  ~FileSelectHelper() override {}
 
   void OnOpenDialogDone(bool result, const std::vector<base::FilePath>& paths) {
     std::vector<content::FileChooserFileInfo> file_info;