efl_ui/image: check image object existence before using it in sizing
authorMike Blumenkrantz <zmike@samsung.com>
Wed, 29 May 2019 13:25:14 +0000 (09:25 -0400)
committerWonki Kim <wonki_.kim@samsung.com>
Mon, 3 Jun 2019 07:04:03 +0000 (16:04 +0900)
Summary:
when triggered before the image is loaded, this code cannot be run

@fix
Depends on D8978

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8979

src/lib/elementary/efl_ui_image.c

index 11305e9..b4abeec 100644 (file)
@@ -820,17 +820,15 @@ _efl_ui_image_sizing_eval(Evas_Object *obj)
    evas_object_size_hint_min_set(obj, minw, minh);
    evas_object_size_hint_max_set(obj, maxw, maxh);
 
-   //Retained way. Nothing does, if either way hasn't been changed.
-   if (!sd->edje)
+   if (sd->img)
      {
-        efl_gfx_image_orientation_set(sd->img, sd->orient);
-     }
+        //Retained way. Nothing does, if either way hasn't been changed.
+        if (!sd->edje)
+          efl_gfx_image_orientation_set(sd->img, sd->orient);
 
-   if (sd->img)
-   {
-      _image_sizing_eval(sd, sd->img);
-      if (sd->prev_img) _image_sizing_eval(sd, sd->prev_img);
-   }
+        _image_sizing_eval(sd, sd->img);
+        if (sd->prev_img) _image_sizing_eval(sd, sd->prev_img);
+     }
 }
 
 static void