drm/amd/pp: silence a static checker warning
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 23 Mar 2018 11:39:03 +0000 (14:39 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 3 Apr 2018 17:52:57 +0000 (12:52 -0500)
This has a static checker warning because "frev" and "crev" can be
uninitialized if "info" is NULL.  I just changed the order of the checks
so that we check "info" first.

Reviewed-by: Rex Zhu <Rex.Zhu@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c

index 75a465f..7b26607 100644 (file)
@@ -319,13 +319,13 @@ static int smu8_get_system_info_data(struct pp_hwmgr *hwmgr)
                        GetIndexIntoMasterTable(DATA, IntegratedSystemInfo),
                        &size, &frev, &crev);
 
-       if (crev != 9) {
-               pr_err("Unsupported IGP table: %d %d\n", frev, crev);
+       if (info == NULL) {
+               pr_err("Could not retrieve the Integrated System Info Table!\n");
                return -EINVAL;
        }
 
-       if (info == NULL) {
-               pr_err("Could not retrieve the Integrated System Info Table!\n");
+       if (crev != 9) {
+               pr_err("Unsupported IGP table: %d %d\n", frev, crev);
                return -EINVAL;
        }