mt76: mt7615: fix potential overflow on large shift
authorRyder Lee <ryder.lee@mediatek.com>
Wed, 21 Apr 2021 22:20:03 +0000 (06:20 +0800)
committerFelix Fietkau <nbd@nbd.name>
Sat, 19 Jun 2021 07:22:47 +0000 (09:22 +0200)
Fix the following static checker warning:
error: undefined (user controlled) shift '(((1))) << (c->omac_idx)'

Fixes: 402a695b1ae6 ("mt76: mt7615: fix CSA notification for DBDC")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c

index a59bd7af81be2d5a746abb6a5f706e510daee181..fc9cd8da2a119b06f9896a3ccb6e0c88987ba5db 100644 (file)
@@ -411,6 +411,9 @@ mt7615_mcu_rx_csa_notify(struct mt7615_dev *dev, struct sk_buff *skb)
 
        c = (struct mt7615_mcu_csa_notify *)skb->data;
 
+       if (c->omac_idx > EXT_BSSID_MAX)
+               return;
+
        if (ext_phy && ext_phy->omac_mask & BIT_ULL(c->omac_idx))
                mphy = dev->mt76.phy2;