gpiolib: Use short form of ternary operator in gpiod_get_index()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 1 Feb 2022 15:27:57 +0000 (17:27 +0200)
committerBartosz Golaszewski <brgl@bgdev.pl>
Tue, 8 Feb 2022 09:35:59 +0000 (10:35 +0100)
Instead of repeating first argument for true branch, use short
form of the ternary operator, i.e. ?:.

While at it, fix a typo in the comment.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpiolib.c

index e3702bc..daedf82 100644 (file)
@@ -3931,19 +3931,18 @@ struct gpio_desc *__must_check gpiod_get_index(struct device *dev,
         * If a connection label was passed use that, else attempt to use
         * the device name as label
         */
-       ret = gpiod_request(desc, con_id ? con_id : devname);
+       ret = gpiod_request(desc, con_id ?: devname);
        if (ret) {
                if (ret == -EBUSY && flags & GPIOD_FLAGS_BIT_NONEXCLUSIVE) {
                        /*
                         * This happens when there are several consumers for
                         * the same GPIO line: we just return here without
-                        * further initialization. It is a bit if a hack.
+                        * further initialization. It is a bit of a hack.
                         * This is necessary to support fixed regulators.
                         *
                         * FIXME: Make this more sane and safe.
                         */
-                       dev_info(dev, "nonexclusive access to GPIO for %s\n",
-                                con_id ? con_id : devname);
+                       dev_info(dev, "nonexclusive access to GPIO for %s\n", con_id ?: devname);
                        return desc;
                } else {
                        return ERR_PTR(ret);