m68knommu: make 523x CPU reset register addressing consistent
authorGreg Ungerer <gerg@uclinux.org>
Sun, 19 Feb 2012 06:27:23 +0000 (16:27 +1000)
committerGreg Ungerer <gerg@uclinux.org>
Mon, 5 Mar 2012 00:42:25 +0000 (10:42 +1000)
If we make all MCF_RCR (CPU reset register) addressing consistent across all
ColdFire CPU family members that use it then we will be able to remove the
duplicated copies of the code that use it.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
arch/m68k/include/asm/m523xsim.h
arch/m68k/platform/523x/config.c

index f2d21ce..075062d 100644 (file)
@@ -65,8 +65,8 @@
 /*
  *  Reset Control Unit (relative to IPSBAR).
  */
-#define        MCF_RCR                 0x110000
-#define        MCF_RSR                 0x110001
+#define        MCF_RCR                 (MCF_IPSBAR + 0x110000)
+#define        MCF_RSR                 (MCF_IPSBAR + 0x110001)
 
 #define        MCF_RCR_SWRESET         0x80            /* Software reset bit */
 #define        MCF_RCR_FRCSTOUT        0x40            /* Force external reset */
index b47a688..88de213 100644 (file)
@@ -57,7 +57,7 @@ static void __init m523x_fec_init(void)
 static void m523x_cpu_reset(void)
 {
        local_irq_disable();
-       __raw_writeb(MCF_RCR_SWRESET, MCF_IPSBAR + MCF_RCR);
+       __raw_writeb(MCF_RCR_SWRESET, MCF_RCR);
 }
 
 /***************************************************************************/