Code bugs are fixed.

pm_lsensor.c :
 unchecked_value: No check of the return value of "device_get_property(DEVICE_TYPE_DISPLAY, cmd, &tmp_value)".

pm_poll.c :
 leaked_storage: Variable "new_path" going out of scope leaks the storage it points to

diff --git a/pm_lsensor.c b/pm_lsensor.c
index 71d6fdf..92c9a49 100644 (file)
--- a/pm_lsensor.c
+++ b/pm_lsensor.c
@@ -63,10 +63,11 @@ static gboolean alc_handler(gpointer data)
                        } else {
                                int tmp_value;
                                int cmd;
+                               int ret;
                                value = PM_MAX_BRIGHTNESS * (int)light_data.values[0] / 10;
                                COMBINE_DISP_CMD(cmd, PROP_DISPLAY_BRIGHTNESS, DEFAULT_DISPLAY);
-                               device_get_property(DEVICE_TYPE_DISPLAY, cmd, &tmp_value);
-                               if (tmp_value != value) {
+                               ret = device_get_property(DEVICE_TYPE_DISPLAY, cmd, &tmp_value);
+                               if (!ret && (tmp_value != value)) {
                                        set_default_brt(value);
                                        backlight_restore();
                                }

diff --git a/pm_poll.c b/pm_poll.c
index 16eadd7..271f866 100644 (file)
--- a/pm_poll.c
+++ b/pm_poll.c
@@ -266,6 +266,7 @@ int init_pm_poll(int (*pm_callback) (int, PMMsg *))
                adddev = (indev *) malloc(sizeof(indev));
                if (!adddev) {
                        LOGERR("Fail to alloc indev: %s", path_tok);
+                       free(new_path);
                        free(dev_paths);
                        return -1;
                }