[M108 Migration][VD] Disable NAVIGATION popup in TV. 88/289388/5
authorfeifei08.liu <feifei08.liu@samsung.com>
Tue, 7 Mar 2023 02:25:33 +0000 (10:25 +0800)
committerBot Blink <blinkbot@samsung.com>
Mon, 13 Mar 2023 06:24:57 +0000 (06:24 +0000)
NAVIGATION popup show default one which create
by WebEngine.
As WebBrowser owns both WebView and control bar.
It is hard to handle event while popup shows.

After discuss with WebBrowser, disable this popup
at first.

If re-use later, this popup can be implement by
WebBrowser with below APIs:
ewk_view_before_unload_confirm_panel_callback_set
ewk_view_before_unload_confirm_panel_reply

Reference:
- https://review.tizen.org/gerrit/283461/

Change-Id: I8f4d43dd18ecdcb170f96a06d098c345d54e6b4c
Signed-off-by: feifei08.liu <feifei08.liu@samsung.com>
third_party/blink/renderer/core/page/chrome_client.cc

index 63202d5..2e75e15 100644 (file)
@@ -107,6 +107,11 @@ static bool OpenJavaScriptDialog(LocalFrame* frame,
 bool ChromeClient::OpenBeforeUnloadConfirmPanel(const String& message,
                                                 LocalFrame* frame,
                                                 bool is_reload) {
+#if BUILDFLAG(IS_TIZEN_TV)
+  // As WebBrowser has no UX guide for NAVIGATION popup, so disable it.
+  return true;
+#endif
+
   DCHECK(frame);
   return OpenJavaScriptDialog(frame, message, [this, frame, is_reload]() {
     return OpenBeforeUnloadConfirmPanelDelegate(frame, is_reload);