rtlwifi: rtl8192cu: Prevent leaking urb

[ Upstream commit 03128643eb5453a798db5770952c73dc64fcaf00 ]

If usb_submit_urb fails the allocated urb should be unanchored and
released.

Signed-off-by: Reto Schneider <code@reto-schneider.ch>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200622132113.14508-3-code@reto-schneider.ch
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c
index 93b22a5b6878ea3a72cebc987b81772eeea8081a..e524573aa8a095e9164fd9fc0937d52602f5c4ee 100644 (file)
--- a/drivers/net/wireless/realtek/rtlwifi/usb.c
+++ b/drivers/net/wireless/realtek/rtlwifi/usb.c
@@ -752,8 +752,11 @@ static int _rtl_usb_receive(struct ieee80211_hw *hw)
 
                usb_anchor_urb(urb, &rtlusb->rx_submitted);
                err = usb_submit_urb(urb, GFP_KERNEL);
-               if (err)
+               if (err) {
+                       usb_unanchor_urb(urb);
+                       usb_free_urb(urb);
                        goto err_out;
+               }
                usb_free_urb(urb);
        }
        return 0;