ALSA: usb: constify snd_pcm_ops structures
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Fri, 18 Aug 2017 07:45:21 +0000 (13:15 +0530)
committerTakashi Iwai <tiwai@suse.de>
Sat, 19 Aug 2017 09:02:27 +0000 (11:02 +0200)
snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/6fire/pcm.c
sound/usb/caiaq/audio.c
sound/usb/hiface/pcm.c
sound/usb/misc/ua101.c
sound/usb/pcm.c
sound/usb/usx2y/usbusx2yaudio.c
sound/usb/usx2y/usx2yhwdeppcm.c

index 36f4115..224a6a5 100644 (file)
@@ -555,7 +555,7 @@ static snd_pcm_uframes_t usb6fire_pcm_pointer(
        return ret;
 }
 
-static struct snd_pcm_ops pcm_ops = {
+static const struct snd_pcm_ops pcm_ops = {
        .open = usb6fire_pcm_open,
        .close = usb6fire_pcm_close,
        .ioctl = snd_pcm_lib_ioctl,
index 054645f..fb1c1ea 100644 (file)
@@ -338,7 +338,7 @@ unlock:
 }
 
 /* operators for both playback and capture */
-static struct snd_pcm_ops snd_usb_caiaq_ops = {
+static const struct snd_pcm_ops snd_usb_caiaq_ops = {
        .open =         snd_usb_caiaq_substream_open,
        .close =        snd_usb_caiaq_substream_close,
        .ioctl =        snd_pcm_lib_ioctl,
index 33db205..175d8d6 100644 (file)
@@ -513,7 +513,7 @@ static snd_pcm_uframes_t hiface_pcm_pointer(struct snd_pcm_substream *alsa_sub)
        return bytes_to_frames(alsa_sub->runtime, dma_offset);
 }
 
-static struct snd_pcm_ops pcm_ops = {
+static const struct snd_pcm_ops pcm_ops = {
        .open = hiface_pcm_open,
        .close = hiface_pcm_close,
        .ioctl = snd_pcm_lib_ioctl,
index b05cd38..386fbfd 100644 (file)
@@ -890,7 +890,7 @@ static snd_pcm_uframes_t playback_pcm_pointer(struct snd_pcm_substream *subs)
        return ua101_pcm_pointer(ua, &ua->playback);
 }
 
-static struct snd_pcm_ops capture_pcm_ops = {
+static const struct snd_pcm_ops capture_pcm_ops = {
        .open = capture_pcm_open,
        .close = capture_pcm_close,
        .ioctl = snd_pcm_lib_ioctl,
@@ -903,7 +903,7 @@ static struct snd_pcm_ops capture_pcm_ops = {
        .mmap = snd_pcm_lib_mmap_vmalloc,
 };
 
-static struct snd_pcm_ops playback_pcm_ops = {
+static const struct snd_pcm_ops playback_pcm_ops = {
        .open = playback_pcm_open,
        .close = playback_pcm_close,
        .ioctl = snd_pcm_lib_ioctl,
index a4f3390..b9c9a19 100644 (file)
@@ -1690,7 +1690,7 @@ static int snd_usb_substream_capture_trigger(struct snd_pcm_substream *substream
        return -EINVAL;
 }
 
-static struct snd_pcm_ops snd_usb_playback_ops = {
+static const struct snd_pcm_ops snd_usb_playback_ops = {
        .open =         snd_usb_playback_open,
        .close =        snd_usb_playback_close,
        .ioctl =        snd_pcm_lib_ioctl,
@@ -1703,7 +1703,7 @@ static struct snd_pcm_ops snd_usb_playback_ops = {
        .mmap =         snd_pcm_lib_mmap_vmalloc,
 };
 
-static struct snd_pcm_ops snd_usb_capture_ops = {
+static const struct snd_pcm_ops snd_usb_capture_ops = {
        .open =         snd_usb_capture_open,
        .close =        snd_usb_capture_close,
        .ioctl =        snd_pcm_lib_ioctl,
index 612aa7f..f93b355 100644 (file)
@@ -905,7 +905,7 @@ static int snd_usX2Y_pcm_close(struct snd_pcm_substream *substream)
 }
 
 
-static struct snd_pcm_ops snd_usX2Y_pcm_ops = 
+static const struct snd_pcm_ops snd_usX2Y_pcm_ops =
 {
        .open =         snd_usX2Y_pcm_open,
        .close =        snd_usX2Y_pcm_close,
index d51c7fd..0d05052 100644 (file)
@@ -587,7 +587,7 @@ static int snd_usX2Y_usbpcm_close(struct snd_pcm_substream *substream)
 }
 
 
-static struct snd_pcm_ops snd_usX2Y_usbpcm_ops = 
+static const struct snd_pcm_ops snd_usX2Y_usbpcm_ops =
 {
        .open =         snd_usX2Y_usbpcm_open,
        .close =        snd_usX2Y_usbpcm_close,