Fix warning causing error in warning as error (Windows) (dotnet/coreclr#21656)
authorBen Adams <thundercat@illyriad.co.uk>
Mon, 24 Dec 2018 02:09:46 +0000 (02:09 +0000)
committerJan Kotas <jkotas@microsoft.com>
Mon, 24 Dec 2018 02:09:46 +0000 (18:09 -0800)
Commit migrated from https://github.com/dotnet/coreclr/commit/5b0f1a1d183f83a077771feca7cea90b8159863a

src/coreclr/src/vm/jitinterface.cpp

index 0730f37..c7d55b5 100644 (file)
@@ -6033,8 +6033,8 @@ CorInfoHelpFunc CEEInfo::getNewHelperStatic(MethodTable * pMT, bool * pHasSideEf
 
     // Slow helper is the default
     CorInfoHelpFunc helper = CORINFO_HELP_NEWFAST;
-    bool hasFinalizer = pMT->HasFinalizer();
-    bool isComObjectType = pMT->IsComObjectType();
+    BOOL hasFinalizer = pMT->HasFinalizer();
+    BOOL isComObjectType = pMT->IsComObjectType();
 
     if (pHasSideEffects != nullptr)
     {
@@ -6051,7 +6051,7 @@ CorInfoHelpFunc CEEInfo::getNewHelperStatic(MethodTable * pMT, bool * pHasSideEf
         else
 #endif
         {
-            *pHasSideEffects = hasFinalizer;
+            *pHasSideEffects = !!hasFinalizer;
         }
     }