ASoC: intel: sof_sdw: Simplify find_codec_info_acpi
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Mon, 31 Jul 2023 21:42:47 +0000 (16:42 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 31 Jul 2023 22:22:33 +0000 (23:22 +0100)
Use a return rather than a break and an additional range check.

Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20230731214257.444605-14-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/sof_sdw.c

index 6b55bcd..d3222f4 100644 (file)
@@ -1003,14 +1003,10 @@ static inline int find_codec_info_acpi(const u8 *acpi_id)
                return -EINVAL;
 
        for (i = 0; i < ARRAY_SIZE(codec_info_list); i++)
-               if (!memcmp(codec_info_list[i].acpi_id, acpi_id,
-                           ACPI_ID_LEN))
-                       break;
-
-       if (i == ARRAY_SIZE(codec_info_list))
-               return -EINVAL;
+               if (!memcmp(codec_info_list[i].acpi_id, acpi_id, ACPI_ID_LEN))
+                       return i;
 
-       return i;
+       return -EINVAL;
 }
 
 /*