fbdev: remove object duplication in Makefile
authorMasahiro Yamada <masahiroy@kernel.org>
Mon, 6 Jan 2020 08:13:52 +0000 (17:13 +0900)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Wed, 15 Jan 2020 16:31:52 +0000 (17:31 +0100)
The objects in $(fb-objs) $(fb-y) $(fb-m) are linked to fb.ko .

This line adds $(fb-y) to fb-objs, so the objects from $(fb-y) are
listed twice as the dependency of the module.

It works because Kbuild trims the duplicated objects from linking,
but there is no good reason to have this line.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200106081352.27730-1-masahiroy@kernel.org
drivers/video/fbdev/core/Makefile

index 3771031..26cbc96 100644 (file)
@@ -16,7 +16,6 @@ fb-y                            += fbcon_rotate.o fbcon_cw.o fbcon_ud.o \
                                     fbcon_ccw.o
 endif
 endif
-fb-objs                           := $(fb-y)
 
 obj-$(CONFIG_FB_CFB_FILLRECT)  += cfbfillrect.o
 obj-$(CONFIG_FB_CFB_COPYAREA)  += cfbcopyarea.o