fakelb: use list_for_each_entry_safe
authorAlexander Aring <alex.aring@gmail.com>
Sun, 17 May 2015 19:44:59 +0000 (21:44 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Tue, 19 May 2015 09:44:45 +0000 (11:44 +0200)
Iterate and removing items from a list, we should use
list_for_each_entry_safe instead list_for_each_entry to avoid accidents
by removing.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/net/ieee802154/fakelb.c

index cc1c7df..66f99c4 100644 (file)
@@ -215,7 +215,7 @@ static void fakelb_del(struct fakelb_dev_priv *priv)
 static int fakelb_probe(struct platform_device *pdev)
 {
        struct fakelb_priv *priv;
-       struct fakelb_dev_priv *dp;
+       struct fakelb_dev_priv *dp, *tmp;
        int err = -ENOMEM;
        int i;
 
@@ -238,7 +238,7 @@ static int fakelb_probe(struct platform_device *pdev)
        return 0;
 
 err_slave:
-       list_for_each_entry(dp, &priv->list, list)
+       list_for_each_entry_safe(dp, tmp, &priv->list, list)
                fakelb_del(dp);
 err_alloc:
        return err;