watchdog: keembay: Removed timeout update in the TO ISR
authorShruthi Sanil <shruthi.sanil@intel.com>
Mon, 17 May 2021 17:49:50 +0000 (23:19 +0530)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Mon, 21 Jun 2021 06:48:56 +0000 (08:48 +0200)
In the TO ISR removed updating the Timeout value because
its not serving any purpose as the timer would have already expired
and the system would be rebooting.

Fixes: fa0f8d51e90d ("watchdog: Add watchdog driver for Intel Keembay Soc")
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Kris Pan <kris.pan@intel.com>
Signed-off-by: Shruthi Sanil <shruthi.sanil@intel.com>
Link: https://lore.kernel.org/r/20210517174953.19404-7-shruthi.sanil@intel.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/keembay_wdt.c

index 3899322..d8c50b6 100644 (file)
@@ -143,7 +143,6 @@ static irqreturn_t keembay_wdt_to_isr(int irq, void *dev_id)
        struct keembay_wdt *wdt = dev_id;
        struct arm_smccc_res res;
 
-       keembay_wdt_writel(wdt, TIM_WATCHDOG, 1);
        arm_smccc_smc(WDT_ISR_CLEAR, WDT_TO_INT_MASK, 0, 0, 0, 0, 0, 0, &res);
        dev_crit(wdt->wdd.parent, "Intel Keem Bay non-sec wdt timeout.\n");
        emergency_restart();