iommu/mediatek: Log with dev_err_probe when failing to parse dts
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Tue, 12 Jul 2022 21:44:27 +0000 (17:44 -0400)
committerJoerg Roedel <jroedel@suse.de>
Fri, 15 Jul 2022 08:24:52 +0000 (10:24 +0200)
mtk_iommu_mm_dts_parse() can fail with EPROBE_DEFER if not all larbs
have probed yet, so use dev_err_probe() to avoid logging as an error in
that case. Also drop the return value from the message since it's
already printed by dev_err_probe(), and add the missing newline at the
end.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220712214427.544860-1-nfraprado@collabora.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/mtk_iommu.c

index a1c1a3a..1759774 100644 (file)
@@ -1216,7 +1216,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
        if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) {
                ret = mtk_iommu_mm_dts_parse(dev, &match, data);
                if (ret) {
-                       dev_err(dev, "mm dts parse fail(%d).", ret);
+                       dev_err_probe(dev, ret, "mm dts parse fail\n");
                        goto out_runtime_disable;
                }
        } else if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_INFRA)) {