fw_update: fix buffer overflow issue

BZ: 41666

Klocwork scan found a "Buffer Overflow in Bound String Copy" issue
in intel_scu_fw_update.c. This patch fix this issue.

Change-Id: Id328f616f079b42553ffc6cf1d50be3422880f9d
Signed-off-by: Li, Ning <ning.li@intel.com>
Reviewed-on: http://android.intel.com:8080/52601
Reviewed-by: Yang, Bin <bin.yang@intel.com>
Reviewed-by: Du, Alek <alek.du@intel.com>
Tested-by: Tang, HaifengX <haifengx.tang@intel.com>
Reviewed-by: buildbot <buildbot@intel.com>
Tested-by: buildbot <buildbot@intel.com>

diff --git a/drivers/platform/x86/intel_scu_fw_update.c b/drivers/platform/x86/intel_scu_fw_update.c
index 3792f87..55028f6 100644 (file)
--- a/drivers/platform/x86/intel_scu_fw_update.c
+++ b/drivers/platform/x86/intel_scu_fw_update.c
@@ -607,7 +607,7 @@ EXPORT_SYMBOL_GPL(intel_scu_ipc_medfw_upgrade);
 
 static void cur_err(const char *err_info)
 {
-       strncpy(err_buf, err_info, sizeof(err_buf));
+       strncpy(err_buf, err_info, sizeof(err_buf) - 1);
 }
 
 static ssize_t write_dnx(struct file *file, struct kobject *kobj,