glupload: Don't leak caps features
authorSeungha Yang <seungha.yang@navercorp.com>
Fri, 8 Feb 2019 12:38:04 +0000 (21:38 +0900)
committerSeungha Yang <seungha.yang@navercorp.com>
Fri, 8 Feb 2019 12:43:43 +0000 (21:43 +0900)
Create caps features when it is required.

gst-libs/gst/gl/gstglupload.c

index f1108f4..c10c023 100644 (file)
@@ -518,9 +518,7 @@ _dma_buf_upload_transform_caps (gpointer impl, GstGLContext * context,
     GstPadDirection direction, GstCaps * caps)
 {
   struct DmabufUpload *dmabuf = impl;
-  GstCapsFeatures *passthrough =
-      gst_caps_features_from_string
-      (GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION);
+  GstCapsFeatures *passthrough;
   GstCaps *ret;
 
   if (context) {
@@ -532,6 +530,9 @@ _dma_buf_upload_transform_caps (gpointer impl, GstGLContext * context,
       return NULL;
   }
 
+  passthrough = gst_caps_features_from_string
+      (GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION);
+
   if (direction == GST_PAD_SINK) {
     GstCaps *tmp;