validate:reporter: Show report by branches when doing smart reporting
authorThibault Saunier <tsaunier@igalia.com>
Tue, 11 Jun 2019 21:11:42 +0000 (17:11 -0400)
committerThibault Saunier <tsaunier@gnome.org>
Tue, 11 Jun 2019 22:35:15 +0000 (22:35 +0000)
Meaning that instead of getting 1 "Detected on" line per monitor,
there will be one per "branch" like:

    Detected on <audioconvert1:sink, audioconvert1:src, audioresample1:sink, audioresample1:src, smart-adder-adder:sink_0, smart-adder-adder:src, smart-adder-capsfilter:sink, smart-adder-capsfilter:src, capsfilter2:sink, capsfilter2:src, tee1:sink, tee1:src_0>

Making it simpler to read and a bit less verbose.

validate/gst/validate/gst-validate-report.c

index 74267a4f8d94aab7da9c233a8f0700c219343166..67d5f7e4240b29eeb0d48d2c7261616d60dd1782 100644 (file)
@@ -1047,8 +1047,10 @@ gst_validate_report_set_master_report (GstValidateReport * report,
   GList *tmp;
   gboolean add_shadow_report = TRUE;
 
-  if (master_report->reporting_level >= GST_VALIDATE_SHOW_MONITOR)
+  if (master_report->reporting_level >= GST_VALIDATE_SHOW_MONITOR &&
+      master_report->reporting_level != GST_VALIDATE_SHOW_SMART) {
     return FALSE;
+  }
 
   report->master_report = master_report;