[llvm-shlib] Fix the i686 MSVC triple check for listing symbols to export in LLVM...
authorMartin Storsjö <martin@martin.st>
Thu, 9 Sep 2021 08:19:55 +0000 (08:19 +0000)
committerMartin Storsjö <martin@martin.st>
Sat, 11 Sep 2021 16:50:03 +0000 (19:50 +0300)
https://reviews.llvm.org/D47381 / eb46c95c3e7aeba4d183ca614fe238067eddf97f
changed the triples set up by GetHostTriple.cmake for i686 MSVC
from i686-pc-win32 to i686-pc-windows-msvc without changing
the corresponding condition in llvm-shlib.

Since then, the 32 bit x86 build of LLVM-C.dll has contained no
exported symbols at all.

Differential Revision: https://reviews.llvm.org/D109493

llvm/tools/llvm-shlib/CMakeLists.txt

index 76b9a25..db013a8 100644 (file)
@@ -124,7 +124,7 @@ if(LLVM_BUILD_LLVM_C_DYLIB AND MSVC)
   list(REMOVE_DUPLICATES LIB_NAMES)
 
   # The python script needs to know whether symbols are prefixed with underscores or not.
-  if(LLVM_HOST_TRIPLE STREQUAL "i686-pc-win32")
+  if(LLVM_HOST_TRIPLE MATCHES "i?86-.*win.*")
     set(GEN_UNDERSCORE "--underscore")
   else()
     set(GEN_UNDERSCORE "")