bq24190: Simplify code in property_is_writeable
authorPavel Machek <pavel@ucw.cz>
Wed, 27 Dec 2017 09:20:42 +0000 (10:20 +0100)
committerSebastian Reichel <sebastian.reichel@collabora.co.uk>
Mon, 8 Jan 2018 17:40:06 +0000 (18:40 +0100)
Simplify function that should be trivial.

Signed-off-by: Pavel machek <pavel@ucw.cz>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
drivers/power/supply/bq24190_charger.c

index c4335ff..b58df04 100644 (file)
@@ -1199,8 +1199,6 @@ static int bq24190_charger_set_property(struct power_supply *psy,
 static int bq24190_charger_property_is_writeable(struct power_supply *psy,
                enum power_supply_property psp)
 {
-       int ret;
-
        switch (psp) {
        case POWER_SUPPLY_PROP_ONLINE:
        case POWER_SUPPLY_PROP_TEMP_ALERT_MAX:
@@ -1208,13 +1206,10 @@ static int bq24190_charger_property_is_writeable(struct power_supply *psy,
        case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:
        case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
        case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
-               ret = 1;
-               break;
+               return 1;
        default:
-               ret = 0;
+               return 0;
        }
-
-       return ret;
 }
 
 static void bq24190_input_current_limit_work(struct work_struct *work)