nvme: tcp: remove redundant assignment to variable ret
authorColin Ian King <colin.king@canonical.com>
Thu, 5 Sep 2019 14:34:35 +0000 (15:34 +0100)
committerSagi Grimberg <sagi@grimberg.me>
Thu, 12 Sep 2019 15:50:46 +0000 (08:50 -0700)
The variable ret is being initialized with a value that is never read
and is being re-assigned immediately afterwards. The assignment is
redundant and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
drivers/nvme/host/tcp.c

index 0a0263a..4ffd595 100644 (file)
@@ -1824,7 +1824,7 @@ static void nvme_tcp_reconnect_or_remove(struct nvme_ctrl *ctrl)
 static int nvme_tcp_setup_ctrl(struct nvme_ctrl *ctrl, bool new)
 {
        struct nvmf_ctrl_options *opts = ctrl->opts;
-       int ret = -EINVAL;
+       int ret;
 
        ret = nvme_tcp_configure_admin_queue(ctrl, new);
        if (ret)