projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
375a6fd
)
drm/mcde: Fix refcount leak in mcde_dsi_bind
author
Miaoqian Lin
<linmq006@gmail.com>
Wed, 25 May 2022 11:54:11 +0000
(15:54 +0400)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:23:23 +0000
(14:23 +0200)
[ Upstream commit
3a149169e4a2f9127022fec6ef5d71b4e804b3b9
]
Every iteration of for_each_available_child_of_node() decrements
the reference counter of the previous node. There is no decrement
when break out from the loop and results in refcount leak.
Add missing of_node_put() to fix this.
Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link:
https://patchwork.freedesktop.org/patch/msgid/20220525115411.65455-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/mcde/mcde_dsi.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/mcde/mcde_dsi.c
b/drivers/gpu/drm/mcde/mcde_dsi.c
index 180ebbccbedaf0e30c284f117fa78603afc8778d..0b58d7f4ba780e8cd923db26f6a4ff317c2564cf 100644
(file)
--- a/
drivers/gpu/drm/mcde/mcde_dsi.c
+++ b/
drivers/gpu/drm/mcde/mcde_dsi.c
@@
-1111,6
+1111,7
@@
static int mcde_dsi_bind(struct device *dev, struct device *master,
bridge = of_drm_find_bridge(child);
if (!bridge) {
dev_err(dev, "failed to find bridge\n");
+ of_node_put(child);
return -EINVAL;
}
}