dpaa_eth: Use refcount_t for refcount
authorChuhong Yuan <hslester96@gmail.com>
Fri, 2 Aug 2019 16:47:59 +0000 (00:47 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Aug 2019 00:57:54 +0000 (17:57 -0700)
refcount_t is better for reference counters since its
implementation can prevent overflows.
So convert atomic_t ref counters to refcount_t.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
drivers/net/ethernet/freescale/dpaa/dpaa_eth.h

index 9c4d1af..b4b82b9 100644 (file)
@@ -485,7 +485,7 @@ static struct dpaa_bp *dpaa_bpid2pool(int bpid)
 static bool dpaa_bpid2pool_use(int bpid)
 {
        if (dpaa_bpid2pool(bpid)) {
-               atomic_inc(&dpaa_bp_array[bpid]->refs);
+               refcount_inc(&dpaa_bp_array[bpid]->refs);
                return true;
        }
 
@@ -496,7 +496,7 @@ static bool dpaa_bpid2pool_use(int bpid)
 static void dpaa_bpid2pool_map(int bpid, struct dpaa_bp *dpaa_bp)
 {
        dpaa_bp_array[bpid] = dpaa_bp;
-       atomic_set(&dpaa_bp->refs, 1);
+       refcount_set(&dpaa_bp->refs, 1);
 }
 
 static int dpaa_bp_alloc_pool(struct dpaa_bp *dpaa_bp)
@@ -584,7 +584,7 @@ static void dpaa_bp_free(struct dpaa_bp *dpaa_bp)
        if (!bp)
                return;
 
-       if (!atomic_dec_and_test(&bp->refs))
+       if (!refcount_dec_and_test(&bp->refs))
                return;
 
        if (bp->free_buf_cb)
index af320f8..f7e59e8 100644 (file)
@@ -32,6 +32,7 @@
 #define __DPAA_H
 
 #include <linux/netdevice.h>
+#include <linux/refcount.h>
 #include <soc/fsl/qman.h>
 #include <soc/fsl/bman.h>
 
@@ -99,7 +100,7 @@ struct dpaa_bp {
        int (*seed_cb)(struct dpaa_bp *);
        /* bpool can be emptied before freeing by this cb */
        void (*free_buf_cb)(const struct dpaa_bp *, struct bm_buffer *);
-       atomic_t refs;
+       refcount_t refs;
 };
 
 struct dpaa_rx_errors {