Remove empty tracing code
authorHugh Bellamy <hughbellars@gmail.com>
Wed, 13 Jun 2018 16:46:25 +0000 (17:46 +0100)
committerMatt Connew <mconnew@microsoft.com>
Thu, 16 Aug 2018 18:22:05 +0000 (11:22 -0700)
Commit migrated from https://github.com/dotnet/corefx/commit/f5ddd892b2664d0bf9a05b102b331fcf9cda80b5

src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/Atom10FeedFormatter.cs
src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/Atom10ItemFormatter.cs
src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/AtomPub10CategoriesDocumentFormatter.cs
src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/AtomPub10ServiceDocumentFormatter.cs
src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/Rss20FeedFormatter.cs
src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/Rss20ItemFormatter.cs
src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/SyndicationFeedFormatter.cs

index 2657aed..5a595f8 100644 (file)
@@ -123,10 +123,8 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(reader));
             }
-            TraceFeedReadBegin();
 
             ReadFeed(reader);
-            TraceFeedReadEnd();
         }
 
         [SuppressMessage("Microsoft.Design", "CA1033:InterfaceMethodsShouldBeCallableByChildTypes", Justification = "The IXmlSerializable implementation is only for exposing under WCF DataContractSerializer. The funcionality is exposed to derived class through the ReadFrom\\WriteTo methods")]
@@ -136,22 +134,18 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(writer));
             }
-            TraceFeedWriteBegin();
 
             WriteFeed(writer);
-            TraceFeedWriteEnd();
         }
 
         public override void ReadFrom(XmlReader reader)
         {
-            TraceFeedReadBegin();
             if (!CanRead(reader))
             {
                 throw new XmlException(SR.Format(SR.UnknownFeedXml, reader.LocalName, reader.NamespaceURI));
             }
 
             ReadFeed(reader);
-            TraceFeedReadEnd();
         }
 
         public override void WriteTo(XmlWriter writer)
@@ -160,12 +154,10 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(writer));
             }
-            TraceFeedWriteBegin();
 
             writer.WriteStartElement(Atom10Constants.FeedTag, Atom10Constants.Atom10Namespace);
             WriteFeed(writer);
             writer.WriteEndElement();
-            TraceFeedWriteEnd();
         }
 
         internal static void ReadCategory(XmlReader reader, SyndicationCategory category, string version, bool preserveAttributeExtensions, bool preserveElementExtensions, int maxExtensionSize)
@@ -204,10 +196,6 @@ namespace System.ServiceModel.Syndication
                             {
                                 category.AttributeExtensions.Add(new XmlQualifiedName(name, ns), val);
                             }
-                            else
-                            {
-                                TraceSyndicationElementIgnoredOnRead(reader);
-                            }
                         }
                     }
                 }
@@ -228,7 +216,6 @@ namespace System.ServiceModel.Syndication
                         }
                         else if (!preserveElementExtensions)
                         {
-                            TraceSyndicationElementIgnoredOnRead(reader);
                             reader.Skip();
                         }
                         else
@@ -560,9 +547,7 @@ namespace System.ServiceModel.Syndication
             }
 
             SyndicationItem item = CreateItem(feed);
-            TraceItemReadBegin();
             ReadItemFrom(reader, item, feed.BaseUri);
-            TraceItemReadEnd();
             return item;
         }
 
@@ -589,11 +574,9 @@ namespace System.ServiceModel.Syndication
 
         protected virtual void WriteItem(XmlWriter writer, SyndicationItem item, Uri feedBaseUri)
         {
-            TraceItemWriteBegin();
             writer.WriteStartElement(Atom10Constants.EntryTag, Atom10Constants.Atom10Namespace);
             WriteItemContents(writer, item, feedBaseUri);
             writer.WriteEndElement();
-            TraceItemWriteEnd();
         }
 
         protected virtual void WriteItems(XmlWriter writer, IEnumerable<SyndicationItem> items, Uri feedBaseUri)
@@ -655,10 +638,6 @@ namespace System.ServiceModel.Syndication
                         }
                         attrs.Add(new XmlQualifiedName(name, ns), value);
                     }
-                    else
-                    {
-                        TraceSyndicationElementIgnoredOnRead(reader);
-                    }
                 }
             }
             reader.MoveToElement();
@@ -754,10 +733,6 @@ namespace System.ServiceModel.Syndication
                             {
                                 result.AttributeExtensions.Add(new XmlQualifiedName(reader.LocalName, reader.NamespaceURI), reader.Value);
                             }
-                            else
-                            {
-                                TraceSyndicationElementIgnoredOnRead(reader);
-                            }
                         }
                     }
                 }
@@ -817,10 +792,6 @@ namespace System.ServiceModel.Syndication
                                     {
                                         result.AttributeExtensions.Add(new XmlQualifiedName(reader.LocalName, reader.NamespaceURI), reader.Value);
                                     }
-                                    else
-                                    {
-                                        TraceSyndicationElementIgnoredOnRead(reader);
-                                    }
                                 }
                             }
                         }
@@ -868,7 +839,6 @@ namespace System.ServiceModel.Syndication
                                     }
                                     else
                                     {
-                                        TraceSyndicationElementIgnoredOnRead(reader);
                                         reader.Skip();
                                     }
                                 }
@@ -936,10 +906,6 @@ namespace System.ServiceModel.Syndication
                             {
                                 result.AttributeExtensions.Add(new XmlQualifiedName(reader.LocalName, reader.NamespaceURI), reader.Value);
                             }
-                            else
-                            {
-                                TraceSyndicationElementIgnoredOnRead(reader);
-                            }
                         }
                     }
                 }
@@ -966,7 +932,6 @@ namespace System.ServiceModel.Syndication
                                     }
                                     else
                                     {
-                                        TraceSyndicationElementIgnoredOnRead(reader);
                                         reader.Skip();
                                     }
                                 }
@@ -1037,10 +1002,6 @@ namespace System.ServiceModel.Syndication
                         {
                             link.AttributeExtensions.Add(new XmlQualifiedName(reader.LocalName, reader.NamespaceURI), reader.Value);
                         }
-                        else
-                        {
-                            TraceSyndicationElementIgnoredOnRead(reader);
-                        }
                     }
                 }
             }
@@ -1065,7 +1026,6 @@ namespace System.ServiceModel.Syndication
                         }
                         else if (!_preserveElementExtensions)
                         {
-                            SyndicationFeedFormatter.TraceSyndicationElementIgnoredOnRead(reader);
                             reader.Skip();
                         }
                         else
@@ -1139,10 +1099,6 @@ namespace System.ServiceModel.Syndication
                         {
                             result.AttributeExtensions.Add(new XmlQualifiedName(reader.LocalName, reader.NamespaceURI), reader.Value);
                         }
-                        else
-                        {
-                            TraceSyndicationElementIgnoredOnRead(reader);
-                        }
                     }
                 }
             }
@@ -1177,7 +1133,6 @@ namespace System.ServiceModel.Syndication
                                 }
                                 else
                                 {
-                                    TraceSyndicationElementIgnoredOnRead(reader);
                                     reader.Skip();
                                 }
                             }
index ef9fa67..ce2efc7 100644 (file)
@@ -112,10 +112,8 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(reader));
             }
-            SyndicationFeedFormatter.TraceItemReadBegin();
 
             ReadItem(reader);
-            SyndicationFeedFormatter.TraceItemReadEnd();
         }
 
         [SuppressMessage("Microsoft.Design", "CA1033:InterfaceMethodsShouldBeCallableByChildTypes", Justification = "The IXmlSerializable implementation is only for exposing under WCF DataContractSerializer. The funcionality is exposed to derived class through the ReadFrom\\WriteTo methods")]
@@ -125,22 +123,18 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(writer));
             }
-            SyndicationFeedFormatter.TraceItemWriteBegin();
 
             WriteItem(writer);
-            SyndicationFeedFormatter.TraceItemWriteEnd();
         }
 
         public override void ReadFrom(XmlReader reader)
         {
-            SyndicationFeedFormatter.TraceItemReadBegin();
             if (!CanRead(reader))
             {
                 throw new XmlException(SR.Format(SR.UnknownItemXml, reader.LocalName, reader.NamespaceURI));
             }
 
             ReadItem(reader);
-            SyndicationFeedFormatter.TraceItemReadEnd();
         }
 
         public override void WriteTo(XmlWriter writer)
@@ -149,12 +143,10 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(writer));
             }
-            SyndicationFeedFormatter.TraceItemWriteBegin();
             
             writer.WriteStartElement(Atom10Constants.EntryTag, Atom10Constants.Atom10Namespace);
             WriteItem(writer);
             writer.WriteEndElement();
-            SyndicationFeedFormatter.TraceItemWriteEnd();
         }
 
         protected override SyndicationItem CreateItemInstance()
index 6af4ed8..325d353 100644 (file)
@@ -103,10 +103,8 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(reader));
             }
-            TraceCategoriesDocumentReadBegin();
             
             ReadDocument(reader);
-            TraceCategoriesDocumentReadEnd();
         }
 
         [SuppressMessage("Microsoft.Design", "CA1033:InterfaceMethodsShouldBeCallableByChildTypes", Justification = "The IXmlSerializable implementation is only for exposing under WCF DataContractSerializer. The funcionality is exposed to derived class through the ReadFrom\\WriteTo methods")]
@@ -120,10 +118,8 @@ namespace System.ServiceModel.Syndication
             {
                 throw new InvalidOperationException(SR.DocumentFormatterDoesNotHaveDocument);
             }
-            TraceCategoriesDocumentWriteBegin();
 
             WriteDocument(writer);
-            TraceCategoriesDocumentWriteEnd();
         }
 
         public override void ReadFrom(XmlReader reader)
@@ -136,10 +132,8 @@ namespace System.ServiceModel.Syndication
             {
                 throw new XmlException(SR.Format(SR.UnknownDocumentXml, reader.LocalName, reader.NamespaceURI));
             }
-            TraceCategoriesDocumentReadBegin();
 
             ReadDocument(reader);
-            TraceCategoriesDocumentReadEnd();
         }
 
         public override void WriteTo(XmlWriter writer)
@@ -152,28 +146,10 @@ namespace System.ServiceModel.Syndication
             {
                 throw new InvalidOperationException(SR.DocumentFormatterDoesNotHaveDocument);
             }
-            TraceCategoriesDocumentWriteBegin();
             
             writer.WriteStartElement(App10Constants.Prefix, App10Constants.Categories, App10Constants.Namespace);
             WriteDocument(writer);
             writer.WriteEndElement();
-            TraceCategoriesDocumentWriteEnd();
-        }
-
-        internal static void TraceCategoriesDocumentReadBegin()
-        {
-        }
-
-        internal static void TraceCategoriesDocumentReadEnd()
-        {
-        }
-
-        internal static void TraceCategoriesDocumentWriteBegin()
-        {
-        }
-
-        internal static void TraceCategoriesDocumentWriteEnd()
-        {
         }
 
         protected override InlineCategoriesDocument CreateInlineCategoriesDocument()
index 74888e6..2b90785 100644 (file)
@@ -87,10 +87,8 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(reader));
             }
-            TraceServiceDocumentReadBegin();
             
             ReadDocument(reader);
-            TraceServiceDocumentReadEnd();
         }
 
         [SuppressMessage("Microsoft.Design", "CA1033:InterfaceMethodsShouldBeCallableByChildTypes", Justification = "The IXmlSerializable implementation is only for exposing under WCF DataContractSerializer. The funcionality is exposed to derived class through the ReadFrom\\WriteTo methods")]
@@ -104,10 +102,8 @@ namespace System.ServiceModel.Syndication
             {
                 throw new InvalidOperationException(SR.DocumentFormatterDoesNotHaveDocument);
             }
-            TraceServiceDocumentWriteBegin();
 
             WriteDocument(writer);
-            TraceServiceDocumentWriteEnd();
         }
 
         public override void ReadFrom(XmlReader reader)
@@ -122,10 +118,8 @@ namespace System.ServiceModel.Syndication
             {
                 throw new XmlException(SR.Format(SR.UnknownDocumentXml, reader.LocalName, reader.NamespaceURI));
             }
-            TraceServiceDocumentReadBegin();
 
             ReadDocument(reader);
-            TraceServiceDocumentReadEnd();
         }
 
         public override void WriteTo(XmlWriter writer)
@@ -138,12 +132,10 @@ namespace System.ServiceModel.Syndication
             {
                 throw new InvalidOperationException(SR.DocumentFormatterDoesNotHaveDocument);
             }
-            TraceServiceDocumentWriteBegin();
 
             writer.WriteStartElement(App10Constants.Prefix, App10Constants.Service, App10Constants.Namespace);
             WriteDocument(writer);
             writer.WriteEndElement();
-            TraceServiceDocumentWriteEnd();
         }
 
         internal static CategoriesDocument ReadCategories(XmlReader reader, Uri baseUri, CreateInlineCategoriesDelegate inlineCategoriesFactory, CreateReferencedCategoriesDelegate referencedCategoriesFactory, string version, bool preserveElementExtensions, bool preserveAttributeExtensions, int maxExtensionSize)
@@ -163,22 +155,6 @@ namespace System.ServiceModel.Syndication
             }
         }
 
-        internal static void TraceServiceDocumentReadBegin()
-        {
-        }
-
-        internal static void TraceServiceDocumentReadEnd()
-        {
-        }
-
-        internal static void TraceServiceDocumentWriteBegin()
-        {
-        }
-
-        internal static void TraceServiceDocumentWriteEnd()
-        {
-        }
-
         internal static void WriteCategoriesInnerXml(XmlWriter writer, CategoriesDocument categories, Uri baseUri, string version)
         {
             Uri baseUriToWrite = FeedUtils.GetBaseUriToWrite(baseUri, categories.BaseUri);
@@ -243,6 +219,7 @@ namespace System.ServiceModel.Syndication
                         {
                             continue;
                         }
+
                         string val = reader.Value;
                         if (!TryParseAttribute(name, ns, val, inlineCategories, version))
                         {
@@ -250,10 +227,6 @@ namespace System.ServiceModel.Syndication
                             {
                                 inlineCategories.AttributeExtensions.Add(new XmlQualifiedName(reader.LocalName, reader.NamespaceURI), reader.Value);
                             }
-                            else
-                            {
-                                SyndicationFeedFormatter.TraceSyndicationElementIgnoredOnRead(reader);
-                            }
                         }
                     }
                 }
@@ -285,11 +258,6 @@ namespace System.ServiceModel.Syndication
                             {
                                 SyndicationFeedFormatter.CreateBufferIfRequiredAndWriteNode(ref buffer, ref extWriter, reader, maxExtensionSize);
                             }
-                            else
-                            {
-                                SyndicationFeedFormatter.TraceSyndicationElementIgnoredOnRead(reader);
-                                reader.Skip();
-                            }
                         }
                     }
                     LoadElementExtensions(buffer, extWriter, inlineCategories);
@@ -340,14 +308,11 @@ namespace System.ServiceModel.Syndication
                             {
                                 referencedCategories.AttributeExtensions.Add(new XmlQualifiedName(reader.LocalName, reader.NamespaceURI), reader.Value);
                             }
-                            else
-                            {
-                                SyndicationFeedFormatter.TraceSyndicationElementIgnoredOnRead(reader);
-                            }
                         }
                     }
                 }
             }
+
             reader.MoveToElement();
             bool isEmptyElement = reader.IsEmptyElement;
             reader.ReadStartElement();
@@ -365,11 +330,6 @@ namespace System.ServiceModel.Syndication
                             {
                                 SyndicationFeedFormatter.CreateBufferIfRequiredAndWriteNode(ref buffer, ref extWriter, reader, maxExtensionSize);
                             }
-                            else
-                            {
-                                SyndicationFeedFormatter.TraceSyndicationElementIgnoredOnRead(reader);
-                                reader.Skip();
-                            }
                         }
                     }
                     LoadElementExtensions(buffer, extWriter, referencedCategories);
@@ -455,6 +415,7 @@ namespace System.ServiceModel.Syndication
                         {
                             continue;
                         }
+
                         string val = reader.Value;
                         if (!TryParseAttribute(name, ns, val, result, this.Version))
                         {
@@ -462,10 +423,6 @@ namespace System.ServiceModel.Syndication
                             {
                                 result.AttributeExtensions.Add(new XmlQualifiedName(reader.LocalName, reader.NamespaceURI), reader.Value);
                             }
-                            else
-                            {
-                                SyndicationFeedFormatter.TraceSyndicationElementIgnoredOnRead(reader);
-                            }
                         }
                     }
                 }
@@ -511,11 +468,6 @@ namespace System.ServiceModel.Syndication
                         {
                             SyndicationFeedFormatter.CreateBufferIfRequiredAndWriteNode(ref buffer, ref extWriter, reader, _maxExtensionSize);
                         }
-                        else
-                        {
-                            SyndicationFeedFormatter.TraceSyndicationElementIgnoredOnRead(reader);
-                            reader.Skip();
-                        }
                     }
                 }
                 LoadElementExtensions(buffer, extWriter, result);
@@ -558,6 +510,7 @@ namespace System.ServiceModel.Syndication
                             {
                                 continue;
                             }
+
                             string val = reader.Value;
                             if (!TryParseAttribute(name, ns, val, result, this.Version))
                             {
@@ -565,10 +518,6 @@ namespace System.ServiceModel.Syndication
                                 {
                                     result.AttributeExtensions.Add(new XmlQualifiedName(reader.LocalName, reader.NamespaceURI), reader.Value);
                                 }
-                                else
-                                {
-                                    SyndicationFeedFormatter.TraceSyndicationElementIgnoredOnRead(reader);
-                                }
                             }
                         }
                     }
@@ -593,11 +542,6 @@ namespace System.ServiceModel.Syndication
                                 {
                                     SyndicationFeedFormatter.CreateBufferIfRequiredAndWriteNode(ref buffer, ref extWriter, reader, _maxExtensionSize);
                                 }
-                                else
-                                {
-                                    SyndicationFeedFormatter.TraceSyndicationElementIgnoredOnRead(reader);
-                                    reader.Skip();
-                                }
                             }
                         }
                         LoadElementExtensions(buffer, extWriter, result);
@@ -644,6 +588,7 @@ namespace System.ServiceModel.Syndication
                         {
                             continue;
                         }
+
                         string val = reader.Value;
                         if (!TryParseAttribute(name, ns, val, result, this.Version))
                         {
@@ -651,10 +596,6 @@ namespace System.ServiceModel.Syndication
                             {
                                 result.AttributeExtensions.Add(new XmlQualifiedName(reader.LocalName, reader.NamespaceURI), reader.Value);
                             }
-                            else
-                            {
-                                SyndicationFeedFormatter.TraceSyndicationElementIgnoredOnRead(reader);
-                            }
                         }
                     }
                 }
@@ -682,11 +623,6 @@ namespace System.ServiceModel.Syndication
                         {
                             SyndicationFeedFormatter.CreateBufferIfRequiredAndWriteNode(ref buffer, ref extWriter, reader, _maxExtensionSize);
                         }
-                        else
-                        {
-                            SyndicationFeedFormatter.TraceSyndicationElementIgnoredOnRead(reader);
-                            reader.Skip();
-                        }
                     }
                 }
                 LoadElementExtensions(buffer, extWriter, result);
index ee284af..ed47aca 100644 (file)
@@ -136,10 +136,8 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(reader));
             }
-            TraceFeedReadBegin();
 
             ReadFeed(reader);
-            TraceFeedReadEnd();
         }
 
         [SuppressMessage("Microsoft.Design", "CA1033:InterfaceMethodsShouldBeCallableByChildTypes", Justification = "The IXmlSerializable implementation is only for exposing under WCF DataContractSerializer. The funcionality is exposed to derived class through the ReadFrom\\WriteTo methods")]
@@ -149,22 +147,18 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(writer));
             }
-            TraceFeedWriteBegin();
 
             WriteFeed(writer);
-            TraceFeedWriteEnd();
         }
 
         public override void ReadFrom(XmlReader reader)
         {
-            TraceFeedReadBegin();
             if (!CanRead(reader))
             {
                 throw new XmlException(SR.Format(SR.UnknownFeedXml, reader.LocalName, reader.NamespaceURI));
             }
 
             ReadFeed(reader);
-            TraceFeedReadEnd();
         }
 
         public override void WriteTo(XmlWriter writer)
@@ -173,12 +167,10 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(writer));
             }
-            TraceFeedWriteBegin();
 
             writer.WriteStartElement(Rss20Constants.RssTag, Rss20Constants.Rss20Namespace);
             WriteFeed(writer);
             writer.WriteEndElement();
-            TraceFeedWriteEnd();
         }
 
         protected internal override void SetFeed(SyndicationFeed feed)
@@ -187,9 +179,6 @@ namespace System.ServiceModel.Syndication
             _atomSerializer.SetFeed(this.Feed);
         }
 
-        internal static void TraceExtensionsIgnoredOnWrite(string message)
-        {
-        }
 
         internal void ReadItemFrom(XmlReader reader, SyndicationItem result)
         {
@@ -218,9 +207,7 @@ namespace System.ServiceModel.Syndication
             }
 
             SyndicationItem item = CreateItem(feed);
-            TraceItemReadBegin();
             ReadItemFrom(reader, item, feed.BaseUri);
-            TraceItemReadEnd();
             return item;
         }
 
@@ -247,11 +234,9 @@ namespace System.ServiceModel.Syndication
 
         protected virtual void WriteItem(XmlWriter writer, SyndicationItem item, Uri feedBaseUri)
         {
-            TraceItemWriteBegin();
             writer.WriteStartElement(Rss20Constants.ItemTag, Rss20Constants.Rss20Namespace);
             WriteItemContents(writer, item, feedBaseUri);
             writer.WriteEndElement();
-            TraceItemWriteEnd();
         }
 
         protected virtual void WriteItems(XmlWriter writer, IEnumerable<SyndicationItem> items, Uri feedBaseUri)
@@ -300,10 +285,6 @@ namespace System.ServiceModel.Syndication
                         {
                             link.AttributeExtensions.Add(new XmlQualifiedName(reader.LocalName, reader.NamespaceURI), reader.Value);
                         }
-                        else
-                        {
-                            TraceSyndicationElementIgnoredOnRead(reader);
-                        }
                     }
                 }
             }
@@ -352,10 +333,6 @@ namespace System.ServiceModel.Syndication
                         {
                             category.AttributeExtensions.Add(new XmlQualifiedName(name, ns), val);
                         }
-                        else
-                        {
-                            TraceSyndicationElementIgnoredOnRead(reader);
-                        }
                     }
                 }
             }
@@ -402,10 +379,6 @@ namespace System.ServiceModel.Syndication
                             {
                                 result.AttributeExtensions.Add(new XmlQualifiedName(name, ns), val);
                             }
-                            else
-                            {
-                                TraceSyndicationElementIgnoredOnRead(reader);
-                            }
                         }
                     }
                 }
@@ -509,10 +482,6 @@ namespace System.ServiceModel.Syndication
                                             {
                                                 feed.AttributeExtensions.Add(new XmlQualifiedName(name, ns), val);
                                             }
-                                            else
-                                            {
-                                                TraceSyndicationElementIgnoredOnRead(reader);
-                                            }
                                         }
                                     }
                                 }
@@ -536,7 +505,6 @@ namespace System.ServiceModel.Syndication
                                     }
                                     else
                                     {
-                                        TraceSyndicationElementIgnoredOnRead(reader);
                                         reader.Skip();
                                     }
                                 }
@@ -616,10 +584,6 @@ namespace System.ServiceModel.Syndication
                         {
                             link.AttributeExtensions.Add(new XmlQualifiedName(name, ns), val);
                         }
-                        else
-                        {
-                            TraceSyndicationElementIgnoredOnRead(reader);
-                        }
                     }
                 }
             }
@@ -665,10 +629,6 @@ namespace System.ServiceModel.Syndication
                         {
                             person.AttributeExtensions.Add(new XmlQualifiedName(name, ns), val);
                         }
-                        else
-                        {
-                            TraceSyndicationElementIgnoredOnRead(reader);
-                        }
                     }
                 }
             }
@@ -734,10 +694,6 @@ namespace System.ServiceModel.Syndication
                             {
                                 result.AttributeExtensions.Add(new XmlQualifiedName(name, ns), val);
                             }
-                            else
-                            {
-                                TraceSyndicationElementIgnoredOnRead(reader);
-                            }
                         }
                     }
                 }
@@ -823,7 +779,6 @@ namespace System.ServiceModel.Syndication
                                 else
                                 {
                                     // ignore other content
-                                    TraceSyndicationElementIgnoredOnRead(reader);
                                     reader.Skip();
                                 }
                             }
@@ -859,7 +814,6 @@ namespace System.ServiceModel.Syndication
                                 }
                                 else
                                 {
-                                    TraceSyndicationElementIgnoredOnRead(reader);
                                     reader.Skip();
                                 }
                             }
@@ -984,10 +938,6 @@ namespace System.ServiceModel.Syndication
                 {
                     _atomSerializer.WriteFeedAuthorsTo(writer, this.Feed.Authors);
                 }
-                else
-                {
-                    TraceExtensionsIgnoredOnWrite(SR.FeedAuthorsIgnoredOnWrite);
-                }
             }
 
             if (this.Feed.LastUpdatedTime > DateTimeOffset.MinValue)
@@ -1018,9 +968,6 @@ namespace System.ServiceModel.Syndication
                     _atomSerializer.WriteFeedContributorsTo(writer, this.Feed.Contributors);
                 }
                 else
-                {
-                    TraceExtensionsIgnoredOnWrite(SR.FeedContributorsIgnoredOnWrite);
-                }
             }
 
             if (this.Feed.ImageUrl != null)
@@ -1096,17 +1043,6 @@ namespace System.ServiceModel.Syndication
                     _atomSerializer.WriteLink(writer, this.Feed.Links[i], this.Feed.BaseUri);
                 }
             }
-            else
-            {
-                if (this.Feed.Id != null)
-                {
-                    TraceExtensionsIgnoredOnWrite(SR.FeedIdIgnoredOnWrite);
-                }
-                if (this.Feed.Links.Count > 1)
-                {
-                    TraceExtensionsIgnoredOnWrite(SR.FeedLinksIgnoredOnWrite);
-                }
-            }
 
             WriteElementExtensions(writer, this.Feed, this.Version);
             WriteItems(writer, this.Feed.Items, this.Feed.BaseUri);
@@ -1170,10 +1106,6 @@ namespace System.ServiceModel.Syndication
                 {
                     _atomSerializer.WriteItemAuthorsTo(writer, item.Authors);
                 }
-                else
-                {
-                    TraceExtensionsIgnoredOnWrite(SR.ItemAuthorsIgnoredOnWrite);
-                }
             }
 
 #pragma warning disable 56506 // tvish, item.Categories is never null
@@ -1237,7 +1169,6 @@ namespace System.ServiceModel.Syndication
             // serialize the enclosures
             SyndicationLink firstEnclosureLink = null;
             bool passedFirstAlternateLink = false;
-            bool isLinkIgnored = false;
             for (int i = 0; i < item.Links.Count; ++i)
             {
                 if (item.Links[i].RelationshipType == Rss20Constants.EnclosureTag)
@@ -1261,14 +1192,6 @@ namespace System.ServiceModel.Syndication
                 {
                     _atomSerializer.WriteLink(writer, item.Links[i], item.BaseUri);
                 }
-                else
-                {
-                    isLinkIgnored = true;
-                }
-            }
-            if (isLinkIgnored)
-            {
-                TraceExtensionsIgnoredOnWrite(SR.ItemLinksIgnoredOnWrite);
             }
 
             if (item.LastUpdatedTime > DateTimeOffset.MinValue)
@@ -1277,20 +1200,12 @@ namespace System.ServiceModel.Syndication
                 {
                     _atomSerializer.WriteItemLastUpdatedTimeTo(writer, item.LastUpdatedTime);
                 }
-                else
-                {
-                    TraceExtensionsIgnoredOnWrite(SR.ItemLastUpdatedTimeIgnoredOnWrite);
-                }
             }
 
             if (_serializeExtensionsAsAtom)
             {
                 _atomSerializer.WriteContentTo(writer, Atom10Constants.RightsTag, item.Copyright);
             }
-            else
-            {
-                TraceExtensionsIgnoredOnWrite(SR.ItemCopyrightIgnoredOnWrite);
-            }
 
             if (!serializedContentAsDescription)
             {
@@ -1298,10 +1213,6 @@ namespace System.ServiceModel.Syndication
                 {
                     _atomSerializer.WriteContentTo(writer, Atom10Constants.ContentTag, item.Content);
                 }
-                else
-                {
-                    TraceExtensionsIgnoredOnWrite(SR.ItemContentIgnoredOnWrite);
-                }
             }
 
 #pragma warning disable 56506 // tvish, item.COntributors is never null
@@ -1312,10 +1223,6 @@ namespace System.ServiceModel.Syndication
                 {
                     _atomSerializer.WriteItemContributorsTo(writer, item.Contributors);
                 }
-                else
-                {
-                    TraceExtensionsIgnoredOnWrite(SR.ItemContributorsIgnoredOnWrite);
-                }
             }
 
             WriteElementExtensions(writer, item, this.Version);
index d20587d..a77d11d 100644 (file)
@@ -130,10 +130,8 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(reader));
             }
-            SyndicationFeedFormatter.TraceItemReadBegin();
             
             ReadItem(reader);
-            SyndicationFeedFormatter.TraceItemReadEnd();
         }
 
         [SuppressMessage("Microsoft.Design", "CA1033:InterfaceMethodsShouldBeCallableByChildTypes", Justification = "The IXmlSerializable implementation is only for exposing under WCF DataContractSerializer. The funcionality is exposed to derived class through the ReadFrom\\WriteTo methods")]
@@ -143,22 +141,18 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(writer));
             }
-            SyndicationFeedFormatter.TraceItemWriteBegin();
 
             WriteItem(writer);
-            SyndicationFeedFormatter.TraceItemWriteEnd();
         }
 
         public override void ReadFrom(XmlReader reader)
         {
-            SyndicationFeedFormatter.TraceItemReadBegin();
             if (!CanRead(reader))
             {
                 throw new XmlException(SR.Format(SR.UnknownItemXml, reader.LocalName, reader.NamespaceURI));
             }
 
             ReadItem(reader);
-            SyndicationFeedFormatter.TraceItemReadEnd();
         }
 
         public override void WriteTo(XmlWriter writer)
@@ -167,12 +161,10 @@ namespace System.ServiceModel.Syndication
             {
                 throw new ArgumentNullException(nameof(writer));
             }
-            SyndicationFeedFormatter.TraceItemWriteBegin();
 
             writer.WriteStartElement(Rss20Constants.ItemTag, Rss20Constants.Rss20Namespace);
             WriteItem(writer);
             writer.WriteEndElement();
-            SyndicationFeedFormatter.TraceItemWriteEnd();
         }
 
         protected override SyndicationItem CreateItemInstance()
index c29cf73..90c47c1 100644 (file)
@@ -578,42 +578,6 @@ namespace System.ServiceModel.Syndication
             }
         }
 
-        internal static void TraceFeedReadBegin()
-        {
-        }
-
-        internal static void TraceFeedReadEnd()
-        {
-        }
-
-        internal static void TraceFeedWriteBegin()
-        {
-        }
-
-        internal static void TraceFeedWriteEnd()
-        {
-        }
-
-        internal static void TraceItemReadBegin()
-        {
-        }
-
-        internal static void TraceItemReadEnd()
-        {
-        }
-
-        internal static void TraceItemWriteBegin()
-        {
-        }
-
-        internal static void TraceItemWriteEnd()
-        {
-        }
-
-        internal static void TraceSyndicationElementIgnoredOnRead(XmlReader reader)
-        {
-        }
-
         protected abstract SyndicationFeed CreateFeedInstance();
 
         private static T GetNonNullValue<T>(T value, string errorMsg)