ALSA: isa: Fix error return code in snd_cmi8330_probe()
authorZhen Lei <thunder.leizhen@huawei.com>
Wed, 7 Jul 2021 07:40:51 +0000 (15:40 +0800)
committerTakashi Iwai <tiwai@suse.de>
Wed, 7 Jul 2021 11:26:19 +0000 (13:26 +0200)
When 'SB_HW_16' check fails, the error code -ENODEV instead of 0 should be
returned, which is the same as that returned when 'WSS_HW_CMI8330' check
fails.

Fixes: 43bcd973d6d0 ("[ALSA] Add snd_card_set_generic_dev() call to ISA drivers")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210707074051.2663-1-thunder.leizhen@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/cmi8330.c

index 6c59a3eec59b6681fe9addc3a3a78fdd134dfc0a..ef6d0a20efd87bb800e00125ac452e27fdf3a42e 100644 (file)
@@ -551,7 +551,7 @@ static int snd_cmi8330_probe(struct snd_card *card, int dev)
        }
        if (acard->sb->hardware != SB_HW_16) {
                snd_printk(KERN_ERR PFX "SB16 not found during probe\n");
-               return err;
+               return -ENODEV;
        }
 
        snd_wss_out(acard->wss, CS4231_MISC_INFO, 0x40); /* switch on MODE2 */