Btrfs-progs: fsck: don't free @seen cache until we finish searching
authorWang Shilong <wangsl.fnst@cn.fujitsu.com>
Tue, 18 Mar 2014 12:02:42 +0000 (20:02 +0800)
committerDavid Sterba <dsterba@suse.cz>
Fri, 11 Apr 2014 17:05:39 +0000 (19:05 +0200)
@seen cache is used to avoid iterating same block more than once, and
we can not free them until we have finished searching.

Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
cmds-check.c

index 60708d0..74eeac7 100644 (file)
@@ -3892,12 +3892,6 @@ static int run_next_block(struct btrfs_trans_handle *trans,
                remove_cache_extent(nodes, cache);
                free(cache);
        }
-       cache = lookup_cache_extent(seen, bytenr, size);
-       if (cache) {
-               remove_cache_extent(seen, cache);
-               free(cache);
-       }
-
        cache = lookup_cache_extent(extent_cache, bytenr, size);
        if (cache) {
                struct extent_record *rec;
@@ -5914,6 +5908,7 @@ out:
        free_device_cache_tree(&dev_cache);
        free_block_group_tree(&block_group_cache);
        free_device_extent_tree(&dev_extent_cache);
+       free_extent_cache_tree(&seen);
        return ret;
 }